1116912 - [Tablet] Toolbar is hidden when opening a new tab with action mode open while scrolled down

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Missing toolbar

1) Open a new private browsing tab
2) Navigate to a page that can scroll the toolbar off-screen (I used kotaku.com)
3) Scroll down to hide the toolbar
4) Select some text
5) Add a tab via the tab strip

Expected: The toolbar is shown and a new pb tab is open
Actual: The toolbar is hidden and a new pb tab is open

If you move your finger along the screen without the toolbar enough, the toolbar will eventually re-appear.

If you don't scroll before selecting text, sometimes the pb intro screen will render incorrectly, but at the very least the toolbar is present.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Assuming we can do DynamicToolbar.show, this seems easy enough.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Disabling restoring the dynamic toolbar state after text is selected (i.e. keeping it shown by changing the highlighted line in [1] to false) fixes the issue.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java?rev=fbdcb7d48dd9#3358

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Don't hide the dynamic toolbar when it was originally shown but a tab was selected

Makes the behavior more consistent with no action bar displayed, e.g. clicking
a link while in action mode keeps the title bar shown now, as it does without
the action mode displayed.

Also, some clean-up. Note that there's a little jank when the action bar hides
but the toolbar does not hide from view - this is particularly noticeable when
in private mode. I think this could be fixed with an action mode exit
animation. Before I file a bug, do you agree?

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/e72b48d59969

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

NI to uplift.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8549947 [details] [diff] [review]
Don't hide the dynamic toolbar when it was originally shown but a tab was selected

Approval Request Comment
[Feature/regressing bug #]:
  New tablet UI (bug 1014156)

[User impact if declined]:
  Users who follow the (granted, edge case) STR will hit an unpolished feature of the browser - behavior of a hidden dynamic toolbar and the action mode is not consistent with when the dynamic toolbar is shown.

[Describe test coverage new/current, TBPL]: None

[Risks and why]: 
  We change how a hidden dynamic toolbar reappears when the action mode is dismissed - in the worst case, this state becomes even more inconsistent than it already is, which is fairly harmless.

[String/UUID change made/needed]: None

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e72b48d59969

Comment 8

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 38.0a1 (2015-01-18);
Device: Asus Transformer Pad TF300T (Android 4.2.1).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d2f1f3c5ab4
https://hg.mozilla.org/releases/mozilla-beta/rev/55bd32c43abd

Comment 10

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in builds:
Firefox for Android 37.0a2 (2015-01-21);
Firefox for Android 36 Beta 2;
Device: Asus Transformer Pad TF300T (Android 4.2.1).