Open
Bug 1117193
Opened 11 years ago
Updated 4 years ago
Move BatchMessageMover (archive function) to a module
Categories
(Thunderbird :: Folder and Message Lists, enhancement)
Thunderbird
Folder and Message Lists
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: rkent, Assigned: squib)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
24.82 KB,
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
Move the BatchMessageMover (which is currently a constructor in mailWindowOveray.js) in a module under mailnews.
The motivation for this is:
1) Enable sharing of common code between SeaMonkey and Thunderbird
2) Allow testing of message archiving using xpcshell tests
3) Enable use of archive functionality outside of the front end, for example as an automatic method, or as a filter action.
I tried to do this as an incidental change in bug 479823 but then realized that the changes required were too extensive due to dependence on other functions that are only implemented in frontend js.
| Assignee | ||
Comment 1•10 years ago
|
||
Taking this. It's annoyed me for a while, and would make my Send and Archive add-on work better. It'd also probably help the Conversations add-on.
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•10 years ago
|
||
I filed bug 1231857 to handle one of the big parts: moving the identity-heuristic code to mailnews/. That will make it a lot easier to move this into a module (and possibly into XPCOM as well?).
| Assignee | ||
Comment 3•10 years ago
|
||
This moves BatchMessageMover to a module. It depends on the patches in bug 1231857.
I'll need a suite reviewer too, since this de-forks the suite version of BatchMessageMover. Who should I ask?
Attachment #8739561 -
Flags: review?(rkent)
| Reporter | ||
Comment 4•10 years ago
|
||
This is just an un-bitrotted version of attachment 8739561 [details] [diff] [review]
I looked it over, comparing to the previous stuff, and it is fine. r+ to make that point. But this cannot be landed yet as it does depend on another bug (and that bug is held up pending the issue of reparsing the message files to get delivered-to).
Attachment #8739561 -
Attachment is obsolete: true
Attachment #8739561 -
Flags: review?(rkent)
Attachment #8787330 -
Flags: review+
Updated•4 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•