111723 - ENTER key inserts control-C into URL bar (Powerbook only)

Status: VERIFIED FIXED

(SeaMonkey :: Location Bar, defect, P2)

Description

[Bruce Tomlin]

On the Macintosh, the ENTER key generates an 0x03 character code.  The normal
expected UI behavior of the ENTER key in the URL bar to Macintosh users is
identical behavior to the RETURN key, to go to the URL.

When typing the ENTER key into the URL bar, Mozilla 0.9.6 inserts a control-C
into the URL.  This is probably the cause of bug ID 99235, which itself causes
bug 85026.  Bug 85026 then persists in localstore.rdf through Mozilla upgrades,
due to bug 99236.

Typing "wwwENTER.mozilla.orgRETURN" into the URL bar results in an alert that
says www.mozilla.org could not be found.  In actuality it is looking for
www^C.mozilla.org, but the ^C is invisible in the font used in the alert.

There seems to be a general lack of support for the ENTER key in the Mac
version, including alerts and even in this text entry box:    That was five
control-C characters, in case you can't see them.  In the font I use for the URL
bar, they are invisible.

Comment 1

[Greg K.]

This WorksForMe using Mac/2001112011. Hitting Enter causes Mozilla to fetch the URL 
that has been entered.

Reporter, please provide the ID # of the Mozilla build you're using.

Comment 2

[Claudius Gayle]

greg, read more carefully. "enter" still sends the URL, but it adds an extra
invisible char.

Bruce, build ID would be nice. I'm considering that maybe this bug should be
expanded to cover support for the Mac 'Enter' key in general(drives me nuts on
alerts). I believe that is non-trivial.

cc Mac, focus, accessibility, geek types :-)

Comment 3

[Andy Lyttle]

Works for me, build 2001112011 on Mac OS 9.2.1, pressing Enter in the address
bar does the same as pressing Return.

Comment 4

[Bruce Tomlin]

I'm using build 2001112011 on a PB G3 Firewire, OS 9.2.1, with the Japanese
language support installed.

Further evidence is to type "wwwENTER.mozilla.org" (where ENTER is the enter key
on a Mac keyboard) and start using the arrow key to step through the text. 
You'll notice that it takes a second step to go from after the 'w' to after the
'.'.  Also, you'll notice the completion menu will suddenly go away when the
ENTER key is pressed.

And make sure you are using the correct key.  This is the ENTER key of the
numeric keypad, or the bottom row of a Powerbook keyboard, not the RETURN key in
the main QWERTY area.

Comment 5

[Mike Pinkerton (not reading bugmail)]

whoa there. not correctly handling a common key on the mac keyboard is 'future'?
what if it was the 'e' key?

nominating for beta1 triage.

Comment 6

[Steve Dagley]

Note for folks that keep thinking this is a WORKSFORME - the Enter key on a 
PowerBook keyboard does not generate the same keycode as the Enter key on a 
keyboard w/numeric keypad.  We most definitely have a problem with the former.

Comment 7

[saari (gone)]

Is the bug that we need another binding, or that the keycode on a powerbook is
wrong? If it is the latter, just assign this bug to me. If it is the former,
just add another binding. 

Comment 8

[Mike Pinkerton (not reading bugmail)]

i'll take this. having one of the affected pismo's it drives me crazy that enter
doesn't dismiss dialogs in 6.2

what is the charcode for the powerbook's enter key? anyone know? i don't yet
have a debug build on my pb to check what we're getting.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Attachment: recognize powerbook's enter key code

powerbook uses a different enter keycode than others. recoginize it as special
so we don't interpret the charcode as cntl-c.

Comment 10

[Steve Dagley]

Comment on attachment 61622 [details] [diff] [review]
recognize powerbook's enter key code

r=sdagley

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 61622 [details] [diff] [review]
recognize powerbook's enter key code

sr=sfraser

Comment 12

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 13

[Mike Pinkerton (not reading bugmail)]

laneded, but not on the 097 branch. do we want it there?

Comment 14

[Matthias Versen [:Matti]]

*** Bug 115570 has been marked as a duplicate of this bug. ***

Comment 15

[timeless]

please commit to branch, there's no reason for us to release note this and 
field the several bug reports from people who don't read the release notes when 
we have the fix, it's simple, and it's been approved.

Comment 16

[Mike Pinkerton (not reading bugmail)]

I just landed this on the 097 branch as well. 

Comment 17

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]