Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code

RESOLVED FIXED in Firefox 36

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8543464 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code
Attachment #8543464 - Flags: review?(cpearce)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1117034
Comment on attachment 8543464 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code

Review of attachment 8543464 [details] [diff] [review]:
-----------------------------------------------------------------

Ralph: given that you're uplifting all of media to Aurora for YouTube-MSE, I'll let you make the call as to whether we take this now or delay it until later...
Attachment #8543464 - Flags: review?(cpearce) → review?(giles)
(Assignee)

Comment 3

3 years ago
FWIW this currently breaks the build with recent clangs because of warnings as errors.  I'd be happy to uplift the patch to Aurora as well, if needed.
I think we should land when the patch is ready, but be ready to uplift a version to aurora.
(Assignee)

Comment 5

3 years ago
(In reply to Ralph Giles (:rillian) from comment #4)
> I think we should land when the patch is ready, but be ready to uplift a
> version to aurora.

Great, so can you please r+ the patch?  :-)  It's ready otherwise.
Comment on attachment 8543464 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code

Review of attachment 8543464 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me. I think we might as well get this in so it rides the 37 train rather than having to uplift it from 38 next week.

Sorry for the review delay.
Attachment #8543464 - Flags: review?(giles) → review+
https://hg.mozilla.org/mozilla-central/rev/292a269e6c01
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(Assignee)

Comment 8

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/6c65348fb3c8
status-firefox36: --- → fixed
(Assignee)

Comment 9

3 years ago
Comment on attachment 8543464 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code

This is required for the MSE uplift, I landed it on aurora.  It's safe and all, no string changes etc!
Attachment #8543464 - Flags: approval-mozilla-aurora?
status-firefox37: --- → fixed
Attachment #8543464 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.