Closed Bug 1117261 Opened 10 years ago Closed 10 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37
Tracking Flags:
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code
57.72 KB, patch
rillian
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
Comment on attachment 8543464 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code

Review of attachment 8543464 [details] [diff] [review]:
-----------------------------------------------------------------

Ralph: given that you're uplifting all of media to Aurora for YouTube-MSE, I'll let you make the call as to whether we take this now or delay it until later...
Attachment #8543464 - Flags: review?(cpearce) → review?(giles)
FWIW this currently breaks the build with recent clangs because of warnings as errors.  I'd be happy to uplift the patch to Aurora as well, if needed.
I think we should land when the patch is ready, but be ready to uplift a version to aurora.
(In reply to Ralph Giles (:rillian) from comment #4)
> I think we should land when the patch is ready, but be ready to uplift a
> version to aurora.

Great, so can you please r+ the patch?  :-)  It's ready otherwise.
Comment on attachment 8543464 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code

Review of attachment 8543464 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me. I think we might as well get this in so it rides the 37 train rather than having to uplift it from 38 next week.

Sorry for the review delay.
Attachment #8543464 - Flags: review?(giles) → review+
https://hg.mozilla.org/mozilla-central/rev/292a269e6c01
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8543464 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in DOM media code

This is required for the MSE uplift, I landed it on aurora.  It's safe and all, no string changes etc!
Attachment #8543464 - Flags: approval-mozilla-aurora?
Attachment #8543464 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: