Closed Bug 1117034 (Winconsistent-missing-override) Opened 9 years ago Closed 8 years ago

Correctly handle the clang -Winconsistent-missing-override warning

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

clang ToT has started to emit this warning.  It's a good idea to mark these methods as MOZ_OVERRIDE anyway, so we should handle this by fixing our code accordingly.
Depends on: 1117035
Depends on: 1117036
Depends on: 1117037
Depends on: 1117040
Depends on: 1117038
Depends on: 1117041
Depends on: 1117042
Depends on: 1117043
Depends on: 1117044
Depends on: 1117248
Depends on: 1117261
Depends on: 1117262
Depends on: 1117263
Depends on: 1117264
Depends on: 1117265
Depends on: 1118411
Depends on: 1118413
Depends on: 1118414
Depends on: 1118415
Depends on: 1118417
Depends on: 1118418
Depends on: 1118419
Depends on: 1118420
Depends on: 1118424
Depends on: 1118425
Depends on: 1118426
Depends on: 1118427
Depends on: 1118428
Depends on: 1118429
Depends on: 1118430
Depends on: 1118432
Depends on: FAIL_ON_WARNINGS
No longer depends on: FAIL_ON_WARNINGS
Depends on: 1108024
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Depends on: 1118546
Depends on: 1118547
Depends on: 1118548
Depends on: 1118550
Depends on: 1118551
Depends on: 1118605
Depends on: 1118606
Depends on: 1118607
Depends on: 1118608
Depends on: 1118609
Depends on: 1118610
Depends on: 1118611
Depends on: 1118612
Depends on: 1118613
Depends on: 1118803
Assignee: nobody → ehsan
Depends on: 1119254
Depends on: 1119256
Depends on: 1119257
Depends on: 1119258
Depends on: 1119259
Depends on: 1119260
Depends on: 1119261
Depends on: 1119263
Depends on: 1119264
Depends on: 1119265
Depends on: 1119267
Depends on: 1119268
Depends on: 1119652
Depends on: 1120547
Depends on: 1120662
Depends on: 1123844
Depends on: 1123878
Depends on: 1123890
Depends on: 1123893
When I first checked in the fix for bug 1123893, I accidentally copypasted *this* bug's bug # in its commit, as noted in bug 1123893 comment 4. I backed out & re-landed with the correct bug number. Adding "leave-open" here, so that this bug doesn't get auto-closed when my first faulty cset is merged to m-c.
Keywords: leave-open
Depends on: 1124784
In case it's useful to anyone else, here's a patch I'm using locally to prevent this warning from being treated as an error.

(This lets me build with clang nightly and with "ac_add_options --enable-warnings-as-errors" in my mozconfig. This warning is still emitted, it's just not treated as an error.)
Depends on: 1109248
Depends on: 1125150
Depends on: 1125178
Depends on: 1125179
Depends on: 1125180
Depends on: 1125182
Depends on: 1125632
Depends on: 1125638
Depends on: 1125673
Depends on: 1126015
In the interest of saving everyone's time, I landed a bunch of random fixes of this sort without review:

https://hg.mozilla.org/integration/mozilla-inbound/rev/45921e3d9773
Depends on: 1126128
Depends on: 1126438
Depends on: 1126447
Depends on: 1128578
Depends on: 1128576
Depends on: 1134931
Depends on: 1135825
Depends on: 1135753
Depends on: 1139603
Depends on: 1143239
Depends on: 1148708
Depends on: 1154776
Depends on: 1169974
I think we can call this FIXED now.

(I'm pretty sure this warning is treated as an error on TreeHerder now, and the only remaining instances of this warning are in 3rd-party code (where fixing is more complicated)).
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Alias: Winconsistent-missing-override
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.