Implement %TypedArray%.prototype.{reduce, reduceRight}

RESOLVED FIXED in mozilla37

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: 446240525, Assigned: 446240525)

Tracking

({dev-doc-complete})

Trunk
mozilla37
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [DocArea=JS])

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
I found we already have a "TypedArrayReduce" method in http://dxr.mozilla.org/mozilla-central/source/js/src/builtin/TypedObject.js#669, so how shall we name this "reduce" method in TypedArray.js?
Flags: needinfo?(evilpies)
(In reply to ziyunfei from comment #1)
> I found we already have a "TypedArrayReduce" method in
> http://dxr.mozilla.org/mozilla-central/source/js/src/builtin/TypedObject.
> js#669, so how shall we name this "reduce" method in TypedArray.js?

That function should be renamed to TypedObjectArrayReduce. R=me on s/TypedArray/TypedObjectArray/ for all functions in TypedObject.js.
Flags: needinfo?(evilpies)
Comment on attachment 8543653 [details] [diff] [review]
s/TypedArray/TypedObjectArray/ in TypedObject.js and TypedObject.cpp

Review of attachment 8543653 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8543653 - Flags: review?(till) → review+
(Assignee)

Comment 5

4 years ago
Attachment #8545157 - Flags: review?(evilpies)
Attachment #8545157 - Flags: review?(evilpies) → review+
https://hg.mozilla.org/mozilla-central/rev/f09142ac24fc
https://hg.mozilla.org/mozilla-central/rev/3b29b9cdedfc
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Great, thanks a lot!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.