Closed Bug 1117820 Opened 5 years ago Closed 5 years ago

Drop support for building with MSVC 2012

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Attachment #8544048 - Flags: review?(mh+mozilla)
Do we need to worry about ensuring that CTP3 is installed as well?
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #2)
> Do we need to worry about ensuring that CTP3 is installed as well?

You mean for MSVC2013?  Not sure... But that would be a separate bug anyway.
Yes, for MSVC2013. Don't we depend on features from that as well that don't exist in a vanilla install? So our minimum supported version isn't actually MSVC2013 but MSVC2013+CTP3.
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #4)
> Yes, for MSVC2013. Don't we depend on features from that as well that don't
> exist in a vanilla install? So our minimum supported version isn't actually
> MSVC2013 but MSVC2013+CTP3.

I don't think so.  What specific features were you thinking of?
Sorry, it was Update 3 I was thinking of (which is what we use in automation as well). I filed bug 1117900 for that discussion to continue.
Blocks: 1118122
Comment on attachment 8544048 [details] [diff] [review]
Drop support for building with MSVC 2012

Review of attachment 8544048 [details] [diff] [review]:
-----------------------------------------------------------------

Some other cruft:
toolkit/mozapps/installer/upload-files.mk has 2012 (and, it turns out, 2010) CRTs handling for JSSHELL_BINS.
dom/media/gtest/TestVideoTrackEncoder.cpp has a test for _MSC_VER < 1800
gfx/2d/Factory.cpp has a test for MSC_VER >= 1600
gfx/2d/Tools.h has a test for _MSC_VER < 1600
gfx/ycbcr/moz.build has a test for CONFIG['_MSC_VER'] == '1400' (!)
ipc/app/sha256.c has tests for _MSC_VER >= 1300 and _MSC_VER >= 1200
js/src/builtin/AtomicsObject.cpp has a test for _MSC_VER >= 1700 && _MSC_VER < 1800
layout/generic/nsFrameState.h has a test for _MSC_VER == 1600
mfbt/Atomics.h has a test for _MSC_VER >= 1800
mfbt/Attributes.h has tests for _MSC_VER >= 1800 and _MSC_VER >= 1700
mfbt/Compiler.h has multiple tests for various versions
mfbt/MSIntTypes.h has tests for _MSC_VER >= 1800 and _MSC_VER > 1000
mfbt/TypedEnumInternal.h has a test for _MSC_VER >= 1700
mfbt/tests/TestTypedEnum.cpp has a test for _MSC_VER >= 1700
toolkit/crashreporter/client/crashreporter_win.cpp has a test for _MSC_VER >= 1400

I probably missed some.
Attachment #8544048 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #7)
> Some other cruft:
> toolkit/mozapps/installer/upload-files.mk has 2012 (and, it turns out, 2010)
> CRTs handling for JSSHELL_BINS.
> dom/media/gtest/TestVideoTrackEncoder.cpp has a test for _MSC_VER < 1800
> gfx/2d/Factory.cpp has a test for MSC_VER >= 1600
> gfx/2d/Tools.h has a test for _MSC_VER < 1600
> gfx/ycbcr/moz.build has a test for CONFIG['_MSC_VER'] == '1400' (!)
> ipc/app/sha256.c has tests for _MSC_VER >= 1300 and _MSC_VER >= 1200
> js/src/builtin/AtomicsObject.cpp has a test for _MSC_VER >= 1700 && _MSC_VER
> < 1800
> layout/generic/nsFrameState.h has a test for _MSC_VER == 1600
> mfbt/Atomics.h has a test for _MSC_VER >= 1800
> mfbt/Attributes.h has tests for _MSC_VER >= 1800 and _MSC_VER >= 1700
> mfbt/Compiler.h has multiple tests for various versions
> mfbt/MSIntTypes.h has tests for _MSC_VER >= 1800 and _MSC_VER > 1000
> mfbt/TypedEnumInternal.h has a test for _MSC_VER >= 1700
> mfbt/tests/TestTypedEnum.cpp has a test for _MSC_VER >= 1700
> toolkit/crashreporter/client/crashreporter_win.cpp has a test for _MSC_VER
> >= 1400
> 
> I probably missed some.

I'm planning to get rid of this stuff gradually...
https://hg.mozilla.org/mozilla-central/rev/524915a71a51
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Depends on: 1118647
Blocks: 1119068, 1119071
Depends on: 1123547
No longer blocks: 1120059
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.