Closed Bug 1119068 Opened 5 years ago Closed 5 years ago

Clean up some code used for older unsupported MSVC versions; r=bsmedberg

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #8545573 - Flags: review?(benjamin)
Depends on: 1117820
Assignee: nobody → ehsan
Comment on attachment 8545573 [details] [diff] [review]
Clean up some code used for older unsupported MSVC versions

Review of attachment 8545573 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/WindowsCrtPatch.h
@@ +128,5 @@
>    MOZ_ASSERT(!GetModuleHandleA("msvcr120d.dll"));
>  
>    // Temporary until we fully switch over to VS 2013:
>    MOZ_ASSERT(!GetModuleHandleA("msvcr100.dll"));
>    MOZ_ASSERT(!GetModuleHandleA("msvcr100d.dll"));

You could remove these too if you want.
Comment on attachment 8545573 [details] [diff] [review]
Clean up some code used for older unsupported MSVC versions

This appears to remove a block #elif defined(__GNUC__) && defined(NSS_X86_OR_X64) and that appears at first glance to be accidental not intentional.
Attachment #8545573 - Flags: review?(benjamin) → review-
Attachment #8545573 - Attachment is obsolete: true
Attachment #8547671 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/877bdc5cc13b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.