1119068 - Clean up some code used for older unsupported MSVC versions; r=bsmedberg

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[(no longer active)]

Attachment: Clean up some code used for older unsupported MSVC versions

Comment 2

[(Away)]

Comment on attachment 8545573 [details] [diff] [review]
Clean up some code used for older unsupported MSVC versions

Review of attachment 8545573 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/WindowsCrtPatch.h
@@ +128,5 @@
>    MOZ_ASSERT(!GetModuleHandleA("msvcr120d.dll"));
>  
>    // Temporary until we fully switch over to VS 2013:
>    MOZ_ASSERT(!GetModuleHandleA("msvcr100.dll"));
>    MOZ_ASSERT(!GetModuleHandleA("msvcr100d.dll"));

You could remove these too if you want.

Comment 3

[Benjamin Smedberg]

Comment on attachment 8545573 [details] [diff] [review]
Clean up some code used for older unsupported MSVC versions

This appears to remove a block #elif defined(__GNUC__) && defined(NSS_X86_OR_X64) and that appears at first glance to be accidental not intentional.

Comment 4

[(no longer active)]

Attachment: Clean up some code used for older unsupported MSVC versions

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c47d9b79f2e5 for b2g build bustage

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/877bdc5cc13b