1117972 - Implement new first time experience

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Comment 1

[Gregor Wagner [:gwagner]]

What is this about?

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

Is this for search app?

Comment 3

[Dale Harvey (:daleharvey)]

Yes

Comment 4

[GitHub Autolander Bot]

Attachment: [PullReq] daleharvey:1117972 to mozilla-b2g:master

Comment 5

[Ben Francis [:benfrancis]]

Comment on attachment 8560365 [details] [review]
[PullReq] daleharvey:1117972 to mozilla-b2g:master

r+ from me, with one comment. Nice testing.

Note to UX for UX review: notice that you can't see the OK button on the suggestions notice without scrolling to hide the keyboard.

Comment 6

[Dale Harvey (:daleharvey)]

Test fail looks the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1127939

Trying to debug but having trouble due to https://bugzilla.mozilla.org/show_bug.cgi?id=1129937

Comment 7

[Dale Harvey (:daleharvey)]

Forgot to remove the test file that I had split out 

Green run @ https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=a2bb61697afd

https://github.com/mozilla-b2g/gaia/commit/f496f9e64abecce8cef057e939c289c60ed8b95d

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 8560365 [details] [review]
[PullReq] daleharvey:1117972 to mozilla-b2g:master

Landed

Comment 9

[Hermes Cheng (inactive after July 27, 2015)]

Could you please uplift to v2.2? Thanks.

Comment 10

[GitHub Autolander Bot]

Attachment: [PullReq] daleharvey:test-uplift-2 to mozilla-b2g:v2.2

Comment 11

[Dale Harvey (:daleharvey)]

Comment on attachment 8560365 [details] [review]
[PullReq] daleharvey:1117972 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Part of feature 2.2 development
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 12

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue is verified fixed on Flame 3.0

The FTE Phone Tour has been updated to reflect the new way that the search app displays results, which is 4 app results from bookmarks, marketplace, or E.me at the top and then a list of search options below based off of the search provider being used.

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150210010523
Gaia: 0cf517083f7eb5fc269e1236edba50534f65e3cd
Gecko: 2cb22c058add
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

The verifyme keyword has been added for this bug to be verified on Flame 2.2

Comment 13

[SandKing]

Attachment: Verified video: verify_1117972.mp4

This issue has been verified successfully on latest Flame2.2
STR:
1. Launch Serch bar.
2. Input some keywords.
**You can see the same phenomenon with comment 12
Verify video:" verify_1117972.mp4".

Flame 2.2 build:
Build ID               20150210002516
Gaia Revision          b30c8e4303595a0fcb5b640d673cf8503b954701
Gaia Date              2015-02-10 04:09:47
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3e9fa4e70a1b
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150210.041059
Firmware Date          Tue Feb 10 04:11:10 EST 2015
Bootloader             L1TC000118D0

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d89100cfe2d237a10b7d9a04576fd0fd4eaae50f

Comment 15

[Annabelle]

Attachment: Verified Video:verified_2.2.3gp

This issue has been verified as pass on latest Nightly Flame2.2&Nexus5_2.2 by the STR in Comment 13.

Antual result:The search app displays results, which is 4 app results from bookmarks, marketplace, or E.me at the top and then a list of search options below based off of the search provider being used.

Verified Video:verify_2.2.3gp

Flame 2.2 build:(pass)
Build ID               20150705002505
Gaia Revision          ea11f422b687a982f0a961c9aea7858066561707
Gaia Date              2015-07-02 23:37:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0214b4c1ea0
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150705.040440
Firmware Date          Sun Jul  5 04:04:51 EDT 2015
Bootloader             L1TC000118D0

Nexus5_2.2 build:(pass)
Build ID               20150705160206
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150705.193225
Firmware Date          Sun Jul  5 19:32:44 EDT 2015
Bootloader             HHZ12f