1099157 - [Meta] Refactor search results layout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Comment 1

[Kai-Chih Hu [:khu]]

Are we going to break down into detailed engineering bugs? Thanks.

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

Does this user story have UX spec?

Comment 3

[Eric Pang [:epang] UX]

(In reply to Hermes Cheng[:hermescheng] from comment #2)
> Does this user story have UX spec?

Hi Hermes, I've added links to the UX and Visuals Specs below:

UX Specs:
https://mozilla.app.box.com/files/0/f/2545278347

Visual Specs:
https://mozilla.box.com/s/gpijv051aeivyoxcz72a

Clearing ni on Candice :).

Comment 4

[Kai-Chih Hu [:khu]]

Based on the information I got, the target milestone for this bug could be 2.2 Sprint 4. Please feel free to change it if I am wrong. Thank you very much.

Comment 5

[Hermes Cheng (inactive after July 27, 2015)]

According to UX specs, search results will contain 3 parts: A. app recommendation, B. History results, and C. Search suggestion from provider. The marketplace results will be included in A. So, how does a user differentiate the local results (installed apps) and the marketplace results (suggested installable apps)? Will the name of marketplace results still have "Install" as their prefix?

Comment 6

[Rob MacDonald [:robmac]]

Hi Hermes...

Good question. In previous releases "Install" was used as a prefix. There is no mention of the word "Install" being removed in the spec so let's assume this was an oversight until Francis returns from his PTO next week. I've NI'd him as an FYI. 

- Rob

Comment 7

[Hermes Cheng (inactive after July 27, 2015)]

Thanks Rob. After refactor, the display of FTE for Rocketbar would also be different than previous version (e.g. v2.1). I assume this bug would also include this change. Is my understanding correct?

Comment 8

[Hermes Cheng (inactive after July 27, 2015)]

Another question.
When I tap one of the suggestions from search engine, current behavior is to change the whole results set shown in search app. Will the behavior keep the same after refactor? Or, search app will directly launch a browser and bring user to search provider with search words user tapping.

Comment 9

[Hermes Cheng (inactive after July 27, 2015)]

9 Moztrap test cases:
https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=20&sortfield=name&sortdirection=desc&filter-tag=3080&filter-productversion=217&filter-suite=698

Comment 10

[Eric Pang [:epang] UX]

(In reply to Hermes Cheng[:hermescheng] from comment #7)
> Thanks Rob. After refactor, the display of FTE for Rocketbar would also be
> different than previous version (e.g. v2.1). I assume this bug would also
> include this change. Is my understanding correct?

Hi Hermes, yes that's correct, I'll update the animation.  Rob/Jacqueline flagging you on this so you're aware.  I've opened bug 1114945 for this and marked it as dependent on this bug.

Thanks!

Comment 11

[Eric Pang [:epang] UX]

(In reply to Hermes Cheng[:hermescheng] from comment #8)
> Another question.
> When I tap one of the suggestions from search engine, current behavior is to
> change the whole results set shown in search app. Will the behavior keep the
> same after refactor? Or, search app will directly launch a browser and bring
> user to search provider with search words user tapping.

Hi again, I believe once a suggestion is tapped the results should be launched in the selected search engine.  Francis will be able to confirm once he's back from PTO.

Comment 12

[Francis Djabri [:djabber]]

(In reply to Hermes Cheng[:hermescheng] from comment #5)
> According to UX specs, search results will contain 3 parts: A. app
> recommendation, B. History results, and C. Search suggestion from provider.
> The marketplace results will be included in A. So, how does a user
> differentiate the local results (installed apps) and the marketplace results
> (suggested installable apps)? Will the name of marketplace results still
> have "Install" as their prefix?

Since we don't have instant apps for 2.2., then yes, marketplace results should be prefixed by "Install" as per 2.1

Comment 13

[Francis Djabri [:djabber]]

(In reply to Hermes Cheng[:hermescheng] from comment #8)
> Another question.
> When I tap one of the suggestions from search engine, current behavior is to
> change the whole results set shown in search app. Will the behavior keep the
> same after refactor? Or, search app will directly launch a browser and bring
> user to search provider with search words user tapping.

No - this is actually incorrect behaviour, even for 2.1. Tapping on a search suggestion should launch the browser and direct the user to the search provider's results. This is covered in the 2.2. spec.

Comment 14

[Francis Djabri [:djabber]]

(In reply to Hermes Cheng[:hermescheng] from comment #7)
> Thanks Rob. After refactor, the display of FTE for Rocketbar would also be
> different than previous version (e.g. v2.1). I assume this bug would also
> include this change. Is my understanding correct?

Jacqueline, could you answer this in Rob's absence?

Comment 15

[Hermes Cheng (inactive after July 27, 2015)]

(In reply to Francis Djabri [:djabber] from comment #13)
> (In reply to Hermes Cheng[:hermescheng] from comment #8)
> > Another question.
> > When I tap one of the suggestions from search engine, current behavior is to
> > change the whole results set shown in search app. Will the behavior keep the
> > same after refactor? Or, search app will directly launch a browser and bring
> > user to search provider with search words user tapping.
> 
> No - this is actually incorrect behaviour, even for 2.1. Tapping on a search
> suggestion should launch the browser and direct the user to the search
> provider's results. This is covered in the 2.2. spec.

You are correct. In 2.1 spec [1], tapping on a search suggestion should launch the browser. However, current behavior is unexpected, and I will open a bug for this.

[1] 2.1 UX spec: https://mozilla.app.box.com/s/44utizl9oz4eupyu3fuu/1/2099951272/19507117785/1

Comment 16

[Jacqueline Savory [:jsavory] UX]

It looks like Eric was able to answer the question in comment 10 so I'll remove the flags. If there are still unanswered questions feel free to reflag me.

Comment 17

[Ben Francis [:benfrancis]]

Un-assigning myself from meta bug, dependencies now assigned.

Comment 18

[Hermes Cheng (inactive after July 27, 2015)]

Is this feature descoped from v2.2?

Comment 19

[Dale Harvey (:daleharvey)]

This is landed, blocking bugs are just bugs