[Meta] Refactor search results layout

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: wmathanaraj, Unassigned)

Tracking

({feature})

unspecified
Other
Other
Dependency tree / graph
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

User Story

As Mozilla we need to re-factor the search results display so we can use any search provider so that results are not formatted for the need of one specific search provider.

Acceptance Criteria:

* follow UX guidelines
Comment hidden (empty)
(Reporter)

Updated

5 years ago
User Story: (updated)
Keywords: feature
Whiteboard: [systemsfe]
feature-b2g: --- → 2.2+
Assignee: nobody → bfrancis
Are we going to break down into detailed engineering bugs? Thanks.
QA Whiteboard: [2.2-feature-qa+]
Does this user story have UX spec?
Flags: needinfo?(cserran)
(In reply to Hermes Cheng[:hermescheng] from comment #2)
> Does this user story have UX spec?

Hi Hermes, I've added links to the UX and Visuals Specs below:

UX Specs:
https://mozilla.app.box.com/files/0/f/2545278347

Visual Specs:
https://mozilla.box.com/s/gpijv051aeivyoxcz72a

Clearing ni on Candice :).
Flags: needinfo?(cserran)
Based on the information I got, the target milestone for this bug could be 2.2 Sprint 4. Please feel free to change it if I am wrong. Thank you very much.
Target Milestone: --- → 2.2 S4 (23jan)
QA Whiteboard: [2.2-feature-qa+] → [2.2-feature-qa+][COM=Gaia::Search]
Flags: in-moztrap?(hcheng)
According to UX specs, search results will contain 3 parts: A. app recommendation, B. History results, and C. Search suggestion from provider. The marketplace results will be included in A. So, how does a user differentiate the local results (installed apps) and the marketplace results (suggested installable apps)? Will the name of marketplace results still have "Install" as their prefix?
Flags: needinfo?(epang)
Flags: in-moztrap?(hcheng)
Flags: in-moztrap+
Hi Hermes...

Good question. In previous releases "Install" was used as a prefix. There is no mention of the word "Install" being removed in the spec so let's assume this was an oversight until Francis returns from his PTO next week. I've NI'd him as an FYI. 

- Rob
Flags: needinfo?(epang) → needinfo?(fdjabri)
Thanks Rob. After refactor, the display of FTE for Rocketbar would also be different than previous version (e.g. v2.1). I assume this bug would also include this change. Is my understanding correct?
Another question.
When I tap one of the suggestions from search engine, current behavior is to change the whole results set shown in search app. Will the behavior keep the same after refactor? Or, search app will directly launch a browser and bring user to search provider with search words user tapping.
(In reply to Hermes Cheng[:hermescheng] from comment #7)
> Thanks Rob. After refactor, the display of FTE for Rocketbar would also be
> different than previous version (e.g. v2.1). I assume this bug would also
> include this change. Is my understanding correct?

Hi Hermes, yes that's correct, I'll update the animation.  Rob/Jacqueline flagging you on this so you're aware.  I've opened bug 1114945 for this and marked it as dependent on this bug.

Thanks!
Flags: needinfo?(rmacdonald)
Flags: needinfo?(jsavory)
(In reply to Hermes Cheng[:hermescheng] from comment #8)
> Another question.
> When I tap one of the suggestions from search engine, current behavior is to
> change the whole results set shown in search app. Will the behavior keep the
> same after refactor? Or, search app will directly launch a browser and bring
> user to search provider with search words user tapping.

Hi again, I believe once a suggestion is tapped the results should be launched in the selected search engine.  Francis will be able to confirm once he's back from PTO.

Updated

4 years ago
Status: NEW → ASSIGNED
Depends on: 1117967
Depends on: 1117968
Depends on: 1117969
Depends on: 1117970
Depends on: 1117972
Summary: [User Story] Refactor search results layout → [Meta] Refactor search results layout
(In reply to Hermes Cheng[:hermescheng] from comment #5)
> According to UX specs, search results will contain 3 parts: A. app
> recommendation, B. History results, and C. Search suggestion from provider.
> The marketplace results will be included in A. So, how does a user
> differentiate the local results (installed apps) and the marketplace results
> (suggested installable apps)? Will the name of marketplace results still
> have "Install" as their prefix?

Since we don't have instant apps for 2.2., then yes, marketplace results should be prefixed by "Install" as per 2.1
Flags: needinfo?(fdjabri)
(In reply to Hermes Cheng[:hermescheng] from comment #8)
> Another question.
> When I tap one of the suggestions from search engine, current behavior is to
> change the whole results set shown in search app. Will the behavior keep the
> same after refactor? Or, search app will directly launch a browser and bring
> user to search provider with search words user tapping.

No - this is actually incorrect behaviour, even for 2.1. Tapping on a search suggestion should launch the browser and direct the user to the search provider's results. This is covered in the 2.2. spec.
(In reply to Hermes Cheng[:hermescheng] from comment #7)
> Thanks Rob. After refactor, the display of FTE for Rocketbar would also be
> different than previous version (e.g. v2.1). I assume this bug would also
> include this change. Is my understanding correct?

Jacqueline, could you answer this in Rob's absence?
(In reply to Francis Djabri [:djabber] from comment #13)
> (In reply to Hermes Cheng[:hermescheng] from comment #8)
> > Another question.
> > When I tap one of the suggestions from search engine, current behavior is to
> > change the whole results set shown in search app. Will the behavior keep the
> > same after refactor? Or, search app will directly launch a browser and bring
> > user to search provider with search words user tapping.
> 
> No - this is actually incorrect behaviour, even for 2.1. Tapping on a search
> suggestion should launch the browser and direct the user to the search
> provider's results. This is covered in the 2.2. spec.

You are correct. In 2.1 spec [1], tapping on a search suggestion should launch the browser. However, current behavior is unexpected, and I will open a bug for this.

[1] 2.1 UX spec: https://mozilla.app.box.com/s/44utizl9oz4eupyu3fuu/1/2099951272/19507117785/1
It looks like Eric was able to answer the question in comment 10 so I'll remove the flags. If there are still unanswered questions feel free to reflag me.
Flags: needinfo?(rmacdonald)
Flags: needinfo?(jsavory)
feature-b2g: 2.2+ → ---
Target Milestone: 2.2 S4 (23jan) → ---
Un-assigning myself from meta bug, dependencies now assigned.
Assignee: bfrancis → nobody
Is this feature descoped from v2.2?
Flags: needinfo?(cserran)
Depends on: 1125810
Depends on: 1126811
Depends on: 1126964
Depends on: 1127369
Flags: needinfo?(cserran)
QA Whiteboard: [2.2-feature-qa+][COM=Gaia::Search]
This is landed, blocking bugs are just bugs
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.