1118023 - Update to django-browserid 0.10

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Quite a few exceptions of form:

[2015-01-03 19:45:00,226: INFO/Worker-1055] Loading BROWSERID_VERIFY_CLASS failed: Setting BROWSERID_VERIFY_CLASS not found.
[2015-01-03 19:45:00,226: INFO/Worker-1055] Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/django_browserid/urls.py", line 18, in <module>
    Verify = import_from_setting('BROWSERID_VERIFY_CLASS')
  File "/usr/lib/python2.6/site-packages/django_browserid/util.py", line 38, in import_from_setting
    raise ImproperlyConfigured('Setting {0} not found.'.format(setting))
ImproperlyConfigured: Setting BROWSERID_VERIFY_CLASS not found.

Comment 1

[Ed Morley [:emorley]]

Ah this was fixed in https://github.com/mozilla/django-browserid/commit/d67b3c0e61cf0f887e86608ce9d89334efc1f6c5 and so just needs us to update django-browserid from 0.9 to 0.11+.

Changelog:
https://github.com/mozilla/django-browserid/blob/master/CHANGELOG.rst

Comment 2

[Ed Morley [:emorley]]

Changes between the version we're currently on (which is partway between two versions) and v0.11.1:
https://github.com/mozilla/django-browserid/compare/e8d1d57145401cf3f42993fe84edc32e29e5903f...v0.11.1

Comment 3

[Ed Morley [:emorley]]

Attachment: Update to django-browserid v0.11.1

Browserid login only partly works in my Vagrant environment before this change, so it's hard for me to tell if this regresses anything. Guess we'll just have to see on stage :-)

Comment 4

[Mauro Doglio [:mdoglio]]

Comment on attachment 8597301 [details] [review]
Update to django-browserid v0.11.1

Let's see what happens on stage then

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/702259c18179dfc68514124ad9ad6e5e128f1e38
Bug 1118023 - Update to django-browserid v0.11.1

Changes:
https://github.com/mozilla/django-browserid/compare/e8d1d57145401cf3f42993fe84edc32e29e5903f...v0.11.1

This will fix the spurious "Setting BROWSERID_VERIFY_CLASS not found"
errors in logs, as well as possibly help with people getting logged out
intermittently. It also brings us up to the latest django-browserid
release, which means updating later to a (yet to be released) Django 1.8
compatible version of django-browserid should be much easier.

Using a specific version release of django-browserid (vs the Git zip
archive for a specific revision) also means peep doesn't have to
re-download the package each time.

Comment 6

[Ed Morley [:emorley]]

After deploying I'm seeing 500s in the webconsole on stage, from this endpoint:
https://treeherder.allizom.org/browserid/info/

New Relic says:

ImportError: No module named context_processors

For: django.views.defaults:page_not_found

https://rpm.newrelic.com/accounts/677903/applications/5585473/traced_errors/3691472545/similar_errors?original_error_id=3691472545

Comment 7

[Ed Morley [:emorley]]

We just need to remove django_browserid.context_processors.browserid from TEMPLATE_CONTEXT_PROCESSORS, per:
http://django-browserid.readthedocs.org/en/latest/user/upgrading.html#to-0-10-1

I'd read that section, though most of the changes I spot checked had been made already - but obviously not that one, must have missed it (we're updating from a revision halfway between two released versions, which makes it not clear-cut).

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/42f54236b3e8e96567ae9fdbb9be715be4a26b49
Bug 1118023 - Remove reference to django_browserid.context_processors

Since as of django-browserid v0.10.1 it no longer exists:
http://django-browserid.readthedocs.org/en/latest/user/upgrading.html#to-0-10-1

And was resulting in:
ImportError: No module named context_processors

Comment 9

[Ed Morley [:emorley]]

With that fix, there is still the problem that the /browserid/info/ endpoint has been removed upstream, and no equivalent offered for sites that do not make use of django templates. I've filed upstream https://github.com/mozilla/django-browserid/issues/285 but in the meantime I'll revert the changes here.

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3b0469dbc5c10797866b18ef3bad665ca7042c92
Revert update to django-browserid v0.11.1 (bug 1118023)

This reverts commit 702259c18179dfc68514124ad9ad6e5e128f1e38
and 42f54236b3e8e96567ae9fdbb9be715be4a26b49.

Comment 11

[Ed Morley [:emorley]]

Morphing this to just be about updating from an in-between releases revision of django-browserid to a specific release version (just not the latest), which will at least stop the continual reinstallation of this package on Travis/on deployment. v0.10 is the next release after the revision we're using, and contains no major changes, so let's use that:

https://github.com/mozilla/django-browserid/compare/e8d1d57145401cf3f42993fe84edc32e29e5903f...v0.10

We can then update to 0.11.1 (or 1.0 when it's released, given https://github.com/mozilla/django-browserid/issues/285#issuecomment-96741951) in another bug, when we have more time to figure out the UI changes required. We'll also need to fix the django-browserid in the Vagrant environment, since it's impossible to test either the current or new version at the moment.

Comment 12

[Ed Morley [:emorley]]

Attachment: Update to django-browserid v0.10

Comment 13

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d66e30f22036d9059130965f37a198bc7dd9eced
Bug 1118023 - Update to django-browserid v0.10

Changes:
https://github.com/mozilla/django-browserid/compare/e8d1d57145401cf3f42993fe84edc32e29e5903f...v0.10

Using a specific version release of django-browserid (vs the Git zip
archive for a specific revision) means peep doesn't have to re-download
the package each time.