Closed Bug 1118107 Opened 5 years ago Closed 5 years ago

Simplify the context hierarchy

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: shu, Assigned: shu)

References

Details

Attachments

(6 files, 2 obsolete files)

Now that PJS is being removed, the context hierarchy can be simplified to just:

ExclusiveContext
       |
   JSContext

This bug will also track removal of PJS-specific paths from VM functions.
Blocks: removepjs
Assignee: nobody → shu
Comment on attachment 8544998 [details] [diff] [review]
Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in object ops.

Review of attachment 8544998 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Shape.cpp
@@ +899,5 @@
>      /* Allow only shared (slotless) => unshared (slotful) transition. */
>      MOZ_ASSERT(!((attrs ^ shape->attrs) & JSPROP_SHARED) ||
>                 !(attrs & JSPROP_SHARED));
>  
> +    types::MarkTypePropertyNonData(cx->asExclusiveContext(), obj, shape->propid());

The call to asExclusiveContext() is redundant, cx is already one.
Attachment #8544998 - Flags: review?(lhansen) → review+
Comment on attachment 8544999 [details] [diff] [review]
Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in string and conversion ops.

Review of attachment 8544999 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsnum.cpp
@@ +548,5 @@
>  }
>  
>  MOZ_ALWAYS_INLINE
>  static JSFlatString *
> +LookupDtoaCache(ExclusiveContext *cx, double d)

Since cx is an ExclusiveContext the subsequent call to asExclusiveContext() is redundant.

@@ +560,5 @@
>  }
>  
>  MOZ_ALWAYS_INLINE
>  static void
> +CacheNumber(ExclusiveContext *cx, double d, JSFlatString *str)

Ditto.
Attachment #8544999 - Flags: review?(lhansen) → review+
Attachment #8545000 - Flags: review?(lhansen) → review+
Attachment #8545001 - Flags: review?(lhansen) → review+
Attachment #8545002 - Flags: review?(lhansen) → review+
Attachment #8545003 - Flags: review?(lhansen) → review+
Depends on: 1119292
You need to log in before you can comment on or make changes to this bug.