1118107 - Simplify the context hierarchy

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shu-yu Guo [:shu]]

Now that PJS is being removed, the context hierarchy can be simplified to just:

ExclusiveContext
       |
   JSContext

This bug will also track removal of PJS-specific paths from VM functions.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in object ops.

Comment 2

[Shu-yu Guo [:shu]]

Attachment: Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in string and conversion ops.

Comment 3

[Shu-yu Guo [:shu]]

Attachment: Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in object ops.

Comment 4

[Shu-yu Guo [:shu]]

Attachment: Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in string and conversion ops.

Comment 5

[Shu-yu Guo [:shu]]

Attachment: Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in error reporting functions.

Comment 6

[Shu-yu Guo [:shu]]

Attachment: Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in TypedObject code.

Comment 7

[Shu-yu Guo [:shu]]

Attachment: Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in compartment code.

Comment 8

[Shu-yu Guo [:shu]]

Attachment: Convert ThreadSafeContext -> JSContext and remove PJS paths in FrameIters.

Comment 9

[Lars T Hansen [:lth]]

Comment on attachment 8544998 [details] [diff] [review]
Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in object ops.

Review of attachment 8544998 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Shape.cpp
@@ +899,5 @@
>      /* Allow only shared (slotless) => unshared (slotful) transition. */
>      MOZ_ASSERT(!((attrs ^ shape->attrs) & JSPROP_SHARED) ||
>                 !(attrs & JSPROP_SHARED));
>  
> +    types::MarkTypePropertyNonData(cx->asExclusiveContext(), obj, shape->propid());

The call to asExclusiveContext() is redundant, cx is already one.

Comment 10

[Lars T Hansen [:lth]]

Comment on attachment 8544999 [details] [diff] [review]
Convert ThreadSafeContext -> ExclusiveContext and remove PJS paths in string and conversion ops.

Review of attachment 8544999 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsnum.cpp
@@ +548,5 @@
>  }
>  
>  MOZ_ALWAYS_INLINE
>  static JSFlatString *
> +LookupDtoaCache(ExclusiveContext *cx, double d)

Since cx is an ExclusiveContext the subsequent call to asExclusiveContext() is redundant.

@@ +560,5 @@
>  }
>  
>  MOZ_ALWAYS_INLINE
>  static void
> +CacheNumber(ExclusiveContext *cx, double d, JSFlatString *str)

Ditto.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46c80c517631
https://hg.mozilla.org/mozilla-central/rev/dfa1f0425c65
https://hg.mozilla.org/mozilla-central/rev/db4f4627bbc1
https://hg.mozilla.org/mozilla-central/rev/83490bc39981
https://hg.mozilla.org/mozilla-central/rev/9863f12e48e2
https://hg.mozilla.org/mozilla-central/rev/b1e38a68b8b5