1119292 - Remove ForkJoinContext and ThreadSafeContext

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Lars T Hansen [:lth]]

Removing ForkJoinContext and ThreadSafeContext also means removing the ForkJoin and ThreadPool code.  (I may post this as two patches where the first patch does all the refactoring with some #if 0 blocks, and the second removes now-intert files).

Comment 1

[Lars T Hansen [:lth]]

Attachment: WIP: Remove ForkJoinContext and ThreadLocalContext

This is probably review-ready but I've introduced two FIXMEs to get rid of an executionMode field and an executionMode method, if possible, and I'm going to look into that first.

Comment 2

[Lars T Hansen [:lth]]

(In reply to Lars T Hansen [:lth] from comment #1)

> This is probably review-ready but I've introduced two FIXMEs to get rid of
> an executionMode field and an executionMode method, if possible, and I'm
> going to look into that first.

executionMode ties in closely with VMFunction and I'm going to let Shu deal with that.

Comment 3

[Lars T Hansen [:lth]]

Attachment: Remove ForkJoinContext and ThreadLocalContext

Comment 4

[Shu-yu Guo [:shu]]

Comment on attachment 8547519 [details] [diff] [review]
Remove ForkJoinContext and ThreadLocalContext

Review of attachment 8547519 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CompileWrappers.cpp
@@ -81,5 @@
>  const void *
>  CompileRuntime::addressOfInterruptParUint32()
>  {
>      return runtime()->addressOfInterruptParUint32();
>  }

We should be able to remove this too. Ignore if you do so in a later patch (this is the first one I'm looking at today).

::: js/src/shell/js.cpp
@@ +1003,5 @@
>  {
>      JSContext *cx = (JSContext*)data;
>      JSRuntime *rt = cx->runtime();
>  
> +    if (!cx->allowGC())

It might be clearer to just remove cx->allowGC() in favor of cx->isJSContext(). I'll defer to your taste.

Comment 5

[Lars T Hansen [:lth]]

Try (with suggested changes): https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=756a70c50990

Comment 6

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/572ae2163721

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/572ae2163721