Remove ForkJoinContext and ThreadSafeContext

RESOLVED FIXED in mozilla38

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lth, Assigned: lth)

Tracking

unspecified
mozilla38
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Removing ForkJoinContext and ThreadSafeContext also means removing the ForkJoin and ThreadPool code.  (I may post this as two patches where the first patch does all the refactoring with some #if 0 blocks, and the second removes now-intert files).
This is probably review-ready but I've introduced two FIXMEs to get rid of an executionMode field and an executionMode method, if possible, and I'm going to look into that first.
Blocks: 1119694
Blocks: 1118107
(In reply to Lars T Hansen [:lth] from comment #1)

> This is probably review-ready but I've introduced two FIXMEs to get rid of
> an executionMode field and an executionMode method, if possible, and I'm
> going to look into that first.

executionMode ties in closely with VMFunction and I'm going to let Shu deal with that.
Attachment #8545996 - Attachment is obsolete: true
Attachment #8547519 - Flags: review?(shu)
Comment on attachment 8547519 [details] [diff] [review]
Remove ForkJoinContext and ThreadLocalContext

Review of attachment 8547519 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CompileWrappers.cpp
@@ -81,5 @@
>  const void *
>  CompileRuntime::addressOfInterruptParUint32()
>  {
>      return runtime()->addressOfInterruptParUint32();
>  }

We should be able to remove this too. Ignore if you do so in a later patch (this is the first one I'm looking at today).

::: js/src/shell/js.cpp
@@ +1003,5 @@
>  {
>      JSContext *cx = (JSContext*)data;
>      JSRuntime *rt = cx->runtime();
>  
> +    if (!cx->allowGC())

It might be clearer to just remove cx->allowGC() in favor of cx->isJSContext(). I'll defer to your taste.
Attachment #8547519 - Flags: review?(shu) → review+
https://hg.mozilla.org/mozilla-central/rev/572ae2163721
Assignee: nobody → lhansen
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.