1118182 - [Flame][Dialer]It can't enter corresponding settings page when you tap "Voicemail" and "Fixed Dialing Numbers".

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sue]

Attachment: logcat_1441.txt

[1.Description]:
[Flame v2.2][Dialer]
When you tap "Voicemail" and "Fixed Dialing Numbers" at Call Settings page, the options you tapped is highlighted but it can't enter the corresponding settings page.
Found time:14:41
See attachment:logcat_1441.txt and video.MP4

[2.Testing Steps]: 
1. Insert a SIM card and launch Dialer app.
2. Long press "1" button.
**The "Voicemail number is unavailable" prompt will show up.
3. Tap "Settings" button.
**The Call Settings page shows up.
4. Tap "Voicemail" and "Fixed Dialing Numbers".

[3.Expected Result]: 
3. It will go to "Voicemail" and "Fixed Dialing Numbers" settings normally.

[4.Actual Result]: 
4. The options you tapped will be highlighted but it can't enter the corresponding settings page. 

[5.Reproduction build]: 
Flame 2.2 build:
Gaia-Rev        c2bf20d23851d5fda9f8f0ef0267db5f49152376
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/55f3224d7513
Build-ID        20150104010206
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150104.043402
FW-Date         Sun Jan  4 04:34:12 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]:
Free Test

Comment 1

[Sue]

Attachment: video.MP4

Comment 2

[Johan Lorenzo [:jlorenzo]]

QA wanted for a branch check

Comment 3

[Sue]

Attachment: verify_video.MP4

This issue can not be repro on Woodduck 2.0M and Flame 2.0/2.1, I have uploaded the video of Flame 2.0
See attachment:verify_video.MP4

Comment 4

[Sue]

Flame 2.0 build:
Gaia-Rev        f76014fd2c7528493b90d759c68ec3070233d094
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/aedeb9e38bb9
Build-ID        20150106000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150106.034857
FW-Date         Tue Jan  6 03:49:08 EST 2015
Bootloader      L1TC000118D0

Flame 2.1 build:
Gaia-Rev        b04a8cb7b2482e0a44e6702b48c42283a00b5b1e
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/99cea2c818f6
Build-ID        20150106001308
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150106.034709
FW-Date         Tue Jan  6 03:47:20 EST 2015
Bootloader      L1TC000118D0

Woodduck build:
Gaia-Rev        06b544f8a9ee03754dd3f5020f279cffa7a75804
Gecko-Rev       6b1e24a1cba1d5542bebb503ce05a1ec61ceb7d3
Build-ID        20150107050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2
FW-Incremental  1420578377
FW-Date         Wed Jan  7 05:06:46 CST 2015

Comment 5

[Eric Chang [:ericcc] [:echang]]

Not sure this is related to dialer or settings, ni EJ for help...

Comment 6

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Regression which occurred in 2.2.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Arthur, I think this is a regression because after applying activity_handler. Because dsds_settings is only included when we show root panel as the first panel, in activity scenario, we would lose the reference of DsdsSettings. 

In this patch, I tried to make this reference back when loading call.js and this does fix the problem.

Please help to review this simple patch, thanks ;)

Comment 8

[Johan Lorenzo [:jlorenzo]]

Triage: Regression

Comment 9

[Johan Lorenzo [:jlorenzo]]

Per the patch in comment 7.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8545132 [details] [review]
patch on master

r=me, thanks!

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8545132 [details] [review]
patch on master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 
[User impact] if declined: Users can't enter corresponding settings page when you tap "Voicemail" and "Fixed Dialing Numbers".
[Testing completed]: no, we didn't change any code, we just fix the dependency problem from config.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 12

[bhavana bajaj [:bajaj]]

PLease seek branch approval only once you have done the merge on master. thanks!

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Merged at gaia/master : https://github.com/mozilla-b2g/gaia/commit/dbef5f779f746bc4a59192bd06b9751c6532b7f5

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to bhavana bajaj [:bajaj] from comment #12)
> PLease seek branch approval only once you have done the merge on master.
> thanks!

Sorry for missing this, should I mark this bug resolved to keep the approval process (+auto-uplift) going ?

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Because I just merged this patch to master, let me mark this bug as resolved first :)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e22ce099c1e987b52ee44c7327b0412abd06dbe8

Comment 17

[Sue]

Attachment: logcat_1145.txt

Hi Eric,
This issue has been verified fail on Flame 2.2, the option of "Voicemail" works well, but tap "Fixed Dialing Numbers" will have no response. Could you help with it? Thanks!
Found time:11:45
See attachment:logcat_1145.txt and video.MP4
Rate:5/5

Flame 2.2 build:
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118002501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150118.035516
FW-Date         Sun Jan 18 03:55:27 EST 2015
Bootloader      L1TC000118D0

Comment 18

[Sue]

Attachment: video.MP4

Comment 19

[Eric Chang [:ericcc] [:echang]]

Thanks, bug 1123188 created.

Comment 20

[Sue]

This issue had been verified pass on Bug 1123188, change status as VERIFIED.