1118219 - Remove bluetooth host checking in test_toggle_bluetooth_settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

Per the discussion in gaia-ui-automation, called "Bluetooth tests with remote partner", it was discussed that it would be a good idea to have the bluetooth checking from the host removed, because it would be difficult to get that working from an external lab.

If we make that part of the test depend on whether a testvars variable exists, we could keep that part of the test and control it if we want to have it enabled or not.

Comment 1

[Martijn Wargers (dead)]

Attachment: bluetooth

Something like this?

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8544567 [details] [review]
bluetooth

Looks like the way to go.

If I understood correctly, we won't have a Bluetooth Host at all once we migrate to the new lab. I think we can get rid of it entirely. If we do so, we can also remove everything after:
> self.assertTrue(self.data_layer.get_setting('bluetooth.visible'))

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8544567 [details] [review]
bluetooth

This would work, though I added some comments about additional assertions we could add. Also, I wonder if it's really useful to keep this. Simply not adding (or mistyping) a key to a test variables file would cause this not to run, and it would be hard to know that we're losing coverage.

Comment 4

[Martijn Wargers (dead)]

Ok, I'll just remove the bluetooth host checking part. Making the summary reflect that.

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8544567 [details] [review]
bluetooth

Ok, this should address the feedback/review.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8544567 [details] [review]
bluetooth

r=me with a couple of nits addressed

Comment 7

[Martijn Wargers (dead)]

Ok, addressed the nits.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8544567 [details] [review]
bluetooth

Executed adhoc job[1], we have 2 intermittent failures. Can you look at them?

[1] http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/550

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Martijn: Could you take another look at this? I'd like to include this test in our remote lab suite.

Comment 10

[Martijn Wargers (dead)]

Sorry, I forgot about this bug, because I forgot to assign it to me.
I need to look at the failures mentioned in comment 8. Note that there is some comments in bug 1116744 that might help to solve that.

Also I noticed that Bebe just commented with some improvements for my pull request.

Comment 11

[Martijn Wargers (dead)]

Unfortunately, I got a test failure with the test, which seems like a bug in current master build (bluetooth basically doesn't work). I filed bug 1129693 for that.

Comment 12

[Martijn Wargers (dead)]

Updated the pull request with Florin's comments, I kicked off a new Jenkins try run to see if the intermittent failures are still happening: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/666/

Comment 13

[Martijn Wargers (dead)]

Comment on attachment 8544567 [details] [review]
bluetooth

I don't see any intermittent failures occuring with this Jenkins try run, so I guess that failure has disappeared somehow.
Asking review for review to see if this addressed the comments he added in the pull request.

Comment 14

[Florin Strugariu [:Bebe]]

Comment on attachment 8544567 [details] [review]
bluetooth

test is failing and we need to remove unused dependencies

Comment 15

[Martijn Wargers (dead)]

Comment on attachment 8544567 [details] [review]
bluetooth

I can't reproduce the failure that Florin is seeing, nor is Jenkins affected by it. Tomorrow, Florin is going to try and find out where that failure is coming from.

Comment 16

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/b698598dd5467308f05883d9a81fa8a6fb3414d4

Comment 17

[Martijn Wargers (dead)]

(In reply to Dave Hunt (:davehunt) from comment #9)
> Martijn: Could you take another look at this? I'd like to include this test
> in our remote lab suite.

Dave, I think you can now include it in the remote lab suite.

Comment 18

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Yep, already done. Thanks Martijn!

Comment 19

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I just removed the remaining references to pybluez as it's no longer used:
https://github.com/mozilla-b2g/gaia/commit/d99f069f1ef2ff29fa6d7043cf90e65417367e33