1118338 - Remove external = true rule in test_gallery_switch_to_camera.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

I overlooked something in the review of bug 1111637.
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/manifest.ini#49
external = true should be removed and insted, there should be a skip-if = device == "desktop" rule.
Also the sdcard = true rule can be removed, because that is already set to true at the beginning of the manifest.ini

Comment 1

[Martijn Wargers (dead)]

Attachment: 1118338

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8544680 [details] [review]
1118338

made a small comment about sdcard=true.  if that is not an issue, this patch looks good

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8544680 [details] [review]
1118338

I was able to take a picture just fine without the sdcard.

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8544680 [details] [review]
1118338

Let's keep the sdcard =true tag 
There are devices out there that don't have internal memory like flame

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8544680 [details] [review]
1118338

Updated PR.

Comment 6

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/3bc2c63e52b711ab99705af6c06ceb19f19e2f1f