Closed Bug 1118417 Opened 5 years ago Closed 5 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in parser; r=hsivonen

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8544779 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in parser

Review of attachment 8544779 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the comments addressed.

::: parser/html/nsHtml5Parser.cpp
@@ +166,5 @@
>  {
>    return mExecutor->IsComplete();
>  }
>  
> +nsresult

This change doesn't look right to me. It doesn't match the .h file, AFAICT.

::: parser/html/nsHtml5Parser.h
@@ +184,5 @@
>      
>      /**
>       * True in fragment mode and during synchronous document.write
>       */
> +    bool CanInterrupt();

It seems that this method has become dead code, so let's just remove it.

::: parser/html/nsHtml5TreeOpExecutor.h
@@ +158,3 @@
>   
>      // XXX Does anyone need this?
>      nsIDocShell* GetDocShell()

It would make sense to remove this method while at it. It looks a lot like the reason this method is still here is that it wasn't flagged as an override in the past and, therefore, has failed to get removed when other classes have changed.
Attachment #8544779 - Flags: review?(hsivonen) → review+
https://hg.mozilla.org/mozilla-central/rev/ac69293e8e26
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.