Closed Bug 1118547 Opened 5 years ago Closed 5 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in dom/canvas; r=baku

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8544908 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/canvas

Review of attachment 8544908 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContext.h
@@ +191,5 @@
>  
>      NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_AMBIGUOUS(WebGLContext,
>                                                             nsIDOMWebGLRenderingContext)
>  
> +    virtual JSObject* WrapObject(JSContext* cx) MOZ_OVERRIDE = 0;

aCx
Attachment #8544908 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/c23eeccb2c12
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.