Closed
Bug 1118981
Opened 10 years ago
Closed 10 years ago
font rendering does not always respect fallback delay time
Categories
(Core :: Graphics: Text, defect, P2)
Core
Graphics: Text
Tracking
()
VERIFIED
FIXED
mozilla38
People
(Reporter: mvocom, Assigned: jtd)
References
Details
(Keywords: regression)
Attachments
(2 files)
446.39 KB,
image/png
|
Details | |
1.24 KB,
patch
|
jfkthame
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:35.0) Gecko/20100101 Firefox/35.0 Build ID: 20150106233618 Steps to reproduce: Go to: http://www.roboform.com/download/news-windows Actual results: With FF 35: Initially, the site is displayed in a certain font and after a brief moment the page is re-rendered and a different font is used. Also, many sites in Hebrew are displayed in new different fonts. It seems that some options are missing in "Options -> Content -> Alternative Encoding".
Comment 1•10 years ago
|
||
I am able to reproduce this issue on Windows 7 x64 using Firefox 35 RC (build2), the latest Firefox 36 Aurora, and the latest Firefox 37 Nightly, using the URL provided by Yaron. The issue is a regression: - last good - 2014-09-25 - first bad - 2014-09-26 Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1735ff2bb23e&tochange=818f353b7aa6
Status: UNCONFIRMED → NEW
Component: Untriaged → Graphics: Text
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Assignee | ||
Comment 2•10 years ago
|
||
Possible regression from bug 998869, which landed within the pushlog range listed. > Also, many sites in Hebrew are displayed in new different fonts. Hmmm, that's curious. Do have a few URL's for sites where you see the change?
http://www.news1.co.il/ This is prior to 35: http://s14.postimg.org/syb5qgme9/Old.png And this is with 35: http://s11.postimg.org/66mtvnu6r/FF35.png It happens in many other sites as well.
I don't know if this is relevant: "Windows-1255" does not appear in "Fallback Character Encoding". http://s13.postimg.org/eyh711srb/FF35.png http://s15.postimg.org/l7skk7d63/Old.png
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Yaron from comment #3) > http://www.news1.co.il/ > > This is prior to 35: > http://s14.postimg.org/syb5qgme9/Old.png > > And this is with 35: > http://s11.postimg.org/66mtvnu6r/FF35.png > > It happens in many other sites as well. Thanks, Yaron. Could I ask you to log a separate bug about the Hebrew fallback fonts? My guess is the same set of changes is the cause but it's really a separate issue from the downloadable fonts flashing problem here.
Blocks: 998869
Assignee | ||
Comment 6•10 years ago
|
||
Steps to reproduce: Create a new test profile and set 'gfx.downloadable_fonts.fallback_delay' to 20000 in about:config. 1. Start Firefox with the test profile 2. Clear the browser cache 3. Go to http://www.roboform.com/download/news-windows Result: Headings such as "Version 7.9.11.5 -- Dec 02, 2014" will flash as the font load completes. Expected result: Given that the fallback delay is 20 seconds, elements using downloadable fonts should display as blank text until the fonts are fully loading. No flashing should occur.
Assignee: nobody → jdaggett
Severity: normal → major
Priority: -- → P2
Hardware: x86 → All
Summary: Sites displayed in two different fonts → font rendering does not always respect fallback delay time
Version: 35 Branch → Trunk
Assignee | ||
Updated•10 years ago
|
OS: Windows 7 → All
Thank you John. I appreciate your work. Bug 1119619.
Assignee | ||
Comment 8•10 years ago
|
||
With fallback delay set to 20secs most of the text on the left shouldn't be displayed.
Assignee | ||
Comment 9•10 years ago
|
||
So the problem is that the mSkipDrawing member var is not set when constructing the fontlist. Since the fontlist may include userfonts that are *already* loading, this will lead to the fallback font showing before the load delay time.
Assignee | ||
Comment 10•10 years ago
|
||
Check the load state of userfonts when adding to the fontlist. Set mSkipDrawing as appropriate.
Attachment #8548710 -
Flags: review?(jfkthame)
Comment 11•10 years ago
|
||
Comment on attachment 8548710 [details] [diff] [review] patch, initialize mSkipDrawing for already loading fonts Review of attachment 8548710 [details] [diff] [review]: ----------------------------------------------------------------- Yep, that makes sense.
Updated•10 years ago
|
Attachment #8548710 -
Flags: review?(jfkthame) → review+
Reporter | ||
Comment 12•10 years ago
|
||
Thank you John and Jonathan. What about Bug 1119619? It's a major issue in many pages. See also Bug 604991. @Simon, Can you have a look please?
Assignee | ||
Comment 13•10 years ago
|
||
Pushed to inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/7ed011257a25
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7ed011257a25
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8548710 [details] [diff] [review] patch, initialize mSkipDrawing for already loading fonts Approval Request Comment [Feature/regressing bug #]: Bug 998869 improved lazy loading of downloable fonts but in some instances caused the fallback font display timeout to be ignored, resulting in flashes of fallback font text. [User impact if declined]: flashes of fallback font text in some cases (e.g. the camera app in FxOS, bug 1097233) [Describe test coverage new/current, TBPL]: all downloadable font reftests pass [Risks and why]: change is minor and simply initializes the state of the fontlist more accurately [String/UUID change made/needed]: N/A
Attachment #8548710 -
Flags: approval-mozilla-beta?
Attachment #8548710 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8548710 -
Flags: approval-mozilla-beta?
Attachment #8548710 -
Flags: approval-mozilla-beta+
Attachment #8548710 -
Flags: approval-mozilla-aurora?
Attachment #8548710 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 16•10 years ago
|
||
Pushed to aurora/beta: https://hg.mozilla.org/releases/mozilla-aurora/rev/31cfd9095d71 https://hg.mozilla.org/releases/mozilla-beta/rev/beb62e1ad523
Assignee | ||
Updated•10 years ago
|
Updated•10 years ago
|
Flags: qe-verify+
Comment 18•10 years ago
|
||
Reproduced the initial issue on Firefox 35 RC, build ID: 20150106233618. Confirming this fix on Windows 7 64-bit, Ubuntu 14.04 64-bit and Mac OS X 10.9.5 using: 1. Latest Nightly, build ID: 20150121030203; 2. Latest Aurora, build ID: 20150121004011; 3. Firefox 36 beta 2, build ID: 20150120155007.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•