111909 - middle-click on mailto: link opens a blank tab

Status: RESOLVED DUPLICATE of bug 97032

(SeaMonkey :: Tabbed Browser, defect)

Description

[Adam Hauner]

Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.6+) Gecko/2001112508

Repro:
1. set 'Middle click or control-click of links in a Web page' to checked
2. fine page with link mailto:[e-mail]
3. middle click on it

Actual:
New tab is opened, mail client is starting.
Expected:
Just mail client will be started, because tab with mailto: is IMHO useless.

Comment 1

[[not reading bugmail]]

if tab is not opening, a new window will open on a Mailto: link.

Comment 2

[Boris Zbarsky [:bzbarsky]]

We block new window creation in this case (just open mailcompose, not
mailcompose _and_ new window).  We should also block new tab creation.

Comment 3

[Neil Pryde]

All middle mouse clicks on mailto: links can be disabled by this, small, change
in contentAreaClicks.js:

143 - handleLinkClick(event, linkNode.href);
143 + handleLinkClick(event, linkNode.href.toLowerCase);
195 + if ( href.search( "mailto:" ) >= 0 ) { // bail out on mailto links
196 +   return;

-Neil.

Comment 4

[Neil Pryde]

Oops, line 196 should read

return false;

to prevent a JS strict error.

Comment 5

[Neil Pryde]

Well, you better forget about line 143, because a middle mouse click on 'View
Bugs Already Reported Today' on bugzilla.mozilla.org results in this message:

Please stand by ...
Content-type: text/html
Software error:
Evil code attempted to write stuff to the shadow database. at globals.pl line 201.

For help, please send mail to the webmaster ([e-mail]), giving this
error message and the time and date of the error.

-Neil.

Comment 6

[Niklas Mehner]

Neil:

      if (href.toLowerCase().search( "mailto:" ) == 0) // bail out on mailto links
        return false;

or more simple (if otherwise returning true):
      return (href.toLowerCase().search( "mailto:" ) == 0);

1.) You don't want to change the url. Only lowercase it, while comparing.
2.) Compare with == not >=. The URL might contain "mailto:" somewhere else.

Hope this helps,
  Niklas

Comment 7

[David Hyatt]

Reassigning to new component owner.

Comment 8

[R.K.Aa.]

*** Bug 122329 has been marked as a duplicate of this bug. ***

Comment 9

[Martin Häcker]

I do get the same behaviour for other protocols as well on my mac using
<command-click>.

(Sorry for the spam, just wanted to add myself to the cc list. )

Comment 10

[R.K.Aa.]

*** Bug 179833 has been marked as a duplicate of this bug. ***

Comment 11

[R.K.Aa.]

*** This bug has been marked as a duplicate of 97032 ***