1119128 - eliminate gfxPangoFontGroup and gfxFontconfigUtils

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[John Daggett (:jtd)]

Once the new Linux fontconfig platform fontlist lands (bug 1056479) and appears to be stable, we should be able to eliminate gfxPangoFontGroup and the code in gfxFontconfigUtils.

The nsAutoRefTraits stuff in gfxFontconfigUtils.h needs to be moved to gfxFcPlatformFontList.h and the code in gfxQtPlatform needs to be switched over.

Comment 1

[Masatoshi Kimura [:emk]]

(In reply to John Daggett (:jtd) from comment #0)
> and the code in gfxQtPlatform needs to be switched
> over.

Now the Qt backend is dead thanks to bug 1282866.

Comment 2

[Nicholas Nethercote [inactive]]

I took a look at this just for fun. I can see two places where gfxPangoFontGroup is still used:

- In gfxPlatformGtk::{CreateFontGroup,LookupLocalFont,MakePlatformFont}, as a fallback case if |sUseFcFontList| is false, which happens if gfx.font_rendering.fontconfig.fontlist.enabled is false.

- In gfxFontconfigFontEntry::CopyFontTable(), which has a call to gfxFcPlatformFontList::GetFTLibrary().

Addressing these exceeds my understanding of this code. Perhaps this is what bug 1285533 is about.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Remove unneeded font list code

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Remove unneeded font list code

This removes even more code than the last patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/019aeebf751c
Eliminate gfxPangoFontGroup and gfxFontconfigUtils. r=lsalzman

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/019aeebf751c