Closed Bug 1119128 Opened 5 years ago Closed 3 years ago

eliminate gfxPangoFontGroup and gfxFontconfigUtils

Categories

(Core :: Graphics: Text, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jtd, Assigned: jrmuizel)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

Once the new Linux fontconfig platform fontlist lands (bug 1056479) and appears to be stable, we should be able to eliminate gfxPangoFontGroup and the code in gfxFontconfigUtils.

The nsAutoRefTraits stuff in gfxFontconfigUtils.h needs to be moved to gfxFcPlatformFontList.h and the code in gfxQtPlatform needs to be switched over.
Assignee: jd.bugzilla → nobody
Whiteboard: [gfx-noted]
(In reply to John Daggett (:jtd) from comment #0)
> and the code in gfxQtPlatform needs to be switched
> over.

Now the Qt backend is dead thanks to bug 1282866.
Depends on: 1282866
Depends on: 1285533
I took a look at this just for fun. I can see two places where gfxPangoFontGroup is still used:

- In gfxPlatformGtk::{CreateFontGroup,LookupLocalFont,MakePlatformFont}, as a fallback case if |sUseFcFontList| is false, which happens if gfx.font_rendering.fontconfig.fontlist.enabled is false.

- In gfxFontconfigFontEntry::CopyFontTable(), which has a call to gfxFcPlatformFontList::GetFTLibrary().

Addressing these exceeds my understanding of this code. Perhaps this is what bug 1285533 is about.
Attached patch Remove unneeded font list code (obsolete) — Splinter Review
Assignee: nobody → jmuizelaar
Attachment #8849828 - Flags: review?(jfkthame)
Attachment #8849828 - Flags: review?(lsalzman)
This removes even more code than the last patch.
Attachment #8849828 - Attachment is obsolete: true
Attachment #8849828 - Flags: review?(lsalzman)
Attachment #8849828 - Flags: review?(jfkthame)
Attachment #8850125 - Flags: review?(lsalzman)
Attachment #8850125 - Flags: review?(lsalzman) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/019aeebf751c
Eliminate gfxPangoFontGroup and gfxFontconfigUtils. r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/019aeebf751c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.