Closed
Bug 1119130
Opened 10 years ago
Closed 10 years ago
[TextSelection] Clock tabs should not be selectable
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: twen, Unassigned)
References
Details
Attachments
(1 file)
### STR
1. Open clock app
2. Long press on Timer tab
### Actual
Cursors showed up
### Expected
No cursor/not selectable
### Version
Gaia-Rev d4dac29613076bdba3cb8adc217deadb08a2ac20
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/70de2960aa87
Build-ID 20150107160220
Version 37.0a1
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20150105.192724
FW-Date Mon Jan 5 19:27:36 EST 2015
Bootloader L1TC00011880
Reporter | ||
Updated•10 years ago
|
Blocks: CopyPasteLegacy
QA Whiteboard: [textselection]
Comment 1•10 years ago
|
||
I think this is a clock bug which doesn't apply 'moz-user-select none'. Marcus, any comment?
Flags: needinfo?(m)
Comment 2•10 years ago
|
||
Notes: This occurs with any of the 2 (out of 3) non-active tabs. Once a tab becomes the active tab long-pressing the tab name does not result in the Cut/Paste cursors.
Updated•10 years ago
|
Priority: -- → P2
Comment 4•10 years ago
|
||
Hi Marcus, can you help with this or any person you suggest? thanks.
Flags: needinfo?(m)
Comment 5•10 years ago
|
||
After looking into this more, I actually think this is more complex than initially thought:
- On the latest build from the b2g-flash-tool, long-pressing on a tab (in Clock or any other app that has tabs) causes the app to crash.
- The clock app already has -moz-user-select set on both 'html' and 'body', which should disable all text selection.
I'm currently searching for a better cause or existing bug (as this seems like a platform issue) but haven't had any luck yet.
Flags: needinfo?(m)
Comment 6•10 years ago
|
||
(In reply to Marcus Cavanaugh [:mcav] (MoCo SF) from comment #5)
> After looking into this more, I actually think this is more complex than
> initially thought:
>
> - On the latest build from the b2g-flash-tool, long-pressing on a tab (in
> Clock or any other app that has tabs) causes the app to crash.
>
> - The clock app already has -moz-user-select set on both 'html' and 'body',
> which should disable all text selection.
>
> I'm currently searching for a better cause or existing bug (as this seems
> like a platform issue) but haven't had any luck yet.
Marcus, I didn't see the app crash in recently build. Could you try the latest one or give us the commit which caused the crash problem?
BTW, do you use WebIDE to check the css properties of those tabs?
Flags: needinfo?(m)
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8553280 [details] [review]
[PullReq] mcav:clock-tab-selection to mozilla-b2g:master
The latest build doesn't crash, must have been a transient regression.
Upon further inspection, I discovered a snipped in the docs for "-moz-user-select" that indicates that absolutely-positioned elements don't get to inherit the "-moz-user-select" style, only in Firefox. (Other browsers inherit their respective directives.) Which is silly, if you ask me, but makes this fix straightforward as originally proposed.
Verified fixed on my Flame.
Flags: needinfo?(m)
Attachment #8553280 -
Flags: review?(mmedeiros)
Comment 9•10 years ago
|
||
Comment on attachment 8553280 [details] [review]
[PullReq] mcav:clock-tab-selection to mozilla-b2g:master
LGTM, was not able to select the tabs text after applying the patch. - I also did not know about absolutely-positioned elements, weird behavior..
Attachment #8553280 -
Flags: review?(mmedeiros) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/53930a56c9debb4741f2f6cd09a46a5a3f4e2dd3
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
QA Whiteboard: [textselection] → [COM=Text Selection]
Reporter | ||
Comment 11•10 years ago
|
||
Verified fixed on v2.2 and master.
**v2.2
Gaia-Rev 473cd63f53c855299b719285d9b95e3f2910782f
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4b13c4254e2f
Build-ID 20150329162502
Version 37.0
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20150329.200030
FW-Date Sun Mar 29 20:00:41 EDT 2015
Bootloader L1TC000118D0
**Master
Gaia-Rev be25b16efa19bab8d54be08f8fe45dcc93bf93d0
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/dfe60814eda7
Build-ID 20150330010204
Version 39.0a1
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20150330.043332
FW-Date Mon Mar 30 04:33:44 EDT 2015
Bootloader L1TC000118D0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•