Closed
Bug 1119143
Opened 10 years ago
Closed 10 years ago
[v2.2] Fix rocketbar test failures
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RobertC, Assigned: RobertC)
Details
Attachments
(1 file)
The rocket bar tests are failing because the suggestion setting it set to false in the setUp(). This was done in Bug 1118732
The issue is reproduced locally 5 out of 5.
|
Assignee | |
Updated•10 years ago
|
QA Whiteboard: [fxosqa-auto-s7+]
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8545775 -
Flags: review?(viorela.ioia)
Attachment #8545775 -
Flags: review?(florin.strugariu)
Attachment #8545775 -
Flags: feedback?(dave.hunt)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228
r+, tests are passing with this change: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/562/console
Attachment #8545775 -
Flags: review?(viorela.ioia) → review+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228
This should be added in the setup for all tests as a default test value
Attachment #8545775 -
Flags: review?(florin.strugariu) → review-
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228
I understood this pull wring disregard my previous comment
Attachment #8545775 -
Flags: review- → review+
|
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228
Sorry about that. Thanks for the quick fix!
Attachment #8545775 -
Flags: feedback?(dave.hunt) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•