[v2.2] Fix rocketbar test failures

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: RobertC, Assigned: RobertC)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The rocket bar tests are failing because the suggestion setting it set to false in the setUp(). This was done in Bug 1118732

The issue is reproduced locally 5 out of 5.
(Assignee)

Updated

4 years ago
QA Whiteboard: [fxosqa-auto-s7+]
(Assignee)

Comment 1

4 years ago
Created attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228
Attachment #8545775 - Flags: review?(viorela.ioia)
Attachment #8545775 - Flags: review?(florin.strugariu)
Attachment #8545775 - Flags: feedback?(dave.hunt)
Comment on attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228

r+, tests are passing with this change: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/562/console
Attachment #8545775 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228

This should be added in the setup for all tests as a default test value
Attachment #8545775 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228

I understood this pull wring disregard my previous comment
Attachment #8545775 - Flags: review- → review+
https://github.com/mozilla-b2g/gaia/commit/440ffe9c047fe241827ea6d73bf132b954310897
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8545775 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27228

Sorry about that. Thanks for the quick fix!
Attachment #8545775 - Flags: feedback?(dave.hunt) → feedback+
You need to log in before you can comment on or make changes to this bug.