Closed Bug 1119302 Opened 5 years ago Closed 5 years ago

Implement nsIContentPolicy.shouldProcess for plugin resource loads

Categories

(Core :: Plug-ins, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

39 bytes, text/x-review-board-request
bzbarsky
: review+
Details
Plugin resource loads currently don't use nsIContentPolicy.shouldProcess, which means that we don't have MIME type data for them. This patch fixes that and is necessary for the experiment in bug 1108668.
Assignee: nobody → benjamin
Attached file Reviewboard request
Attachment #8546021 - Flags: review?(bzbarsky)
Comment on attachment 8546021 [details]
Reviewboard request

r+, but please see the reviewboard comments.  I wish it actually set the r+ state here instead of putting me through the extra work... filed bug 1119416.
Attachment #8546021 - Flags: review?(bzbarsky) → review+
Comment on attachment 8546021 [details]
Reviewboard request

Approval Request Comment
[Feature/regressing bug #]: API needed for the experiment in bug 1108668
[User impact if declined]: Can't run the experiment
[Describe test coverage new/current, TBPL]: Manually verified with the experiment code
[Risks and why]: There is a risk that nsIContentPolicy implementations will see new notifications that they didn't expect and will somehow fail. I judge this risk as fairly low, and is mainly a risk with addons.
[String/UUID change made/needed]: None
Attachment #8546021 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/fx-team/rev/621fadc8702b I had to move the code later in the method so that error returns triggered notifications properly.
Flags: needinfo?(benjamin)
https://hg.mozilla.org/mozilla-central/rev/621fadc8702b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8546021 [details]
Reviewboard request

[Triage Comment]
After the merge.
Attachment #8546021 - Flags: approval-mozilla-beta+
Attachment #8546021 - Flags: approval-mozilla-aurora?
Attachment #8546021 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.