Closed Bug 1119302 Opened 5 years ago Closed 5 years ago
IContent Policy .should Process for plugin resource loads
Plugin resource loads currently don't use nsIContentPolicy.shouldProcess, which means that we don't have MIME type data for them. This patch fixes that and is necessary for the experiment in bug 1108668.
Comment on attachment 8546021 [details] Reviewboard request r+, but please see the reviewboard comments. I wish it actually set the r+ state here instead of putting me through the extra work... filed bug 1119416.
Attachment #8546021 - Flags: review?(bzbarsky) → review+
Comment on attachment 8546021 [details] Reviewboard request Approval Request Comment [Feature/regressing bug #]: API needed for the experiment in bug 1108668 [User impact if declined]: Can't run the experiment [Describe test coverage new/current, TBPL]: Manually verified with the experiment code [Risks and why]: There is a risk that nsIContentPolicy implementations will see new notifications that they didn't expect and will somehow fail. I judge this risk as fairly low, and is mainly a risk with addons. [String/UUID change made/needed]: None
Backed out for failures in test_streamNotify.html: https://treeherder.mozilla.org/logviewer.html#?job_id=5277932&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=5278924&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/157873c02e6d
This also failed with this patch: https://treeherder.mozilla.org/logviewer.html#?job_id=5280947&repo=mozilla-inbound
https://hg.mozilla.org/integration/fx-team/rev/621fadc8702b I had to move the code later in the method so that error returns triggered notifications properly.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8546021 [details] Reviewboard request [Triage Comment] After the merge.
https://hg.mozilla.org/releases/mozilla-beta/rev/c447c4b139a9 (this made 37 before the merge)
You need to log in before you can comment on or make changes to this bug.