1119327 - AsyncShutdown completion condition error from TelemetryFile.savePingToFile

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Georg Fritzsche [:gfritzsche]]

Checked on Nightly 2015-01-08.
* run with fresh profile
* navigate to about:telemetry
* quit Firefox

... this produces the error below.

> gfritzsche$ /Applications/FirefoxNightly.app/Contents/MacOS/firefox-bin --no-remote -profile `mktemp -d -t testProfile`
>  
> WARNING: A completion condition encountered an error while we were spinning the event loop. Condition: Telemetry: shutting down Phase: profile-before-change2 State: (none)
> WARNING: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.userPass]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/TelemetryFile.jsm :: this.TelemetryFile.savePingToFile/< :: line 85"  data: no]
> WARNING: this.TelemetryFile.savePingToFile/<@resource://gre/modules/TelemetryFile.jsm:85:25
> TaskImpl_run@resource://gre/modules/Task.jsm:314:39
> TaskImpl@resource://gre/modules/Task.jsm:275:2
> createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:13
> Task_spawn@resource://gre/modules/Task.jsm:164:11
> this.TelemetryFile.savePingToFile@resource://gre/modules/TelemetryFile.jsm:83:0
> this.TelemetryFile.savePing/<@resource://gre/modules/TelemetryFile.jsm:105:12
> TaskImpl_run@resource://gre/modules/Task.jsm:314:39
> Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:22
> this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:6
> this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:36
> Spinner.prototype.observe@resource://gre/modules/AsyncShutdown.jsm:366:8

Comment 1

[Georg Fritzsche [:gfritzsche]]

This is not happening on Nightly 2014-12-28.
Jim, looks like this is a regression from bug 1109931?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Actually looks like a regression from bug 1102937.

ping.payload.simpleMeasurements.UITelemetry.toolbars.currentSearchEngine should be a string (I think) but is instead an nsISearchEngine object, and JSON.stringify encounters an error when it tries to read the value of currentSearchEngine.iconURI.userPass.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

All we're interested in there is a unique identifier, so I'm going to add a ".name" to browser/modules/BrowserUITelemetry.jsm line 559, and see if that fixes the error.  Jim, can I ask you for the review once I verify it fixes the error?

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Attachment: Use the .name instead of the entire search engine object.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8546076 [details] [diff] [review]
Use the .name instead of the entire search engine object.

Review of attachment 8546076 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! You should check that about:telemetry works too because I think this also broke about:telemetry.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

(I was actually checking about:telemetry for other stuff, so, yeah, this fixes that.  :)

Comment 8

[Carsten Book [:Tomcat]]

Hi, can we get a try run for this changes ? Thanks!

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Certainly!  https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ed5dcade21e9
(It's mostly green so far, with no failures, but a bunch of stuff still running…)

Comment 11

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/3c61d595997e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c61d595997e

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This made the uplift.
https://hg.mozilla.org/releases/mozilla-aurora/rev/3c61d595997e