Refactor controlTags logic to be in sync with SWFFile definition

RESOLVED INCOMPLETE

Status

Firefox Graveyard
Shumway
RESOLVED INCOMPLETE
3 years ago
2 years ago

People

(Reporter: yury, Unassigned)

Tracking

({regression})

Trunk
regression

Details

(Reporter)

Description

3 years ago
Currently we have https://github.com/yurydelendik/shumway/blob/8b5616ca41b66ab5d8ddf36b961cfaebacd55cd1/src/flash/display/MovieClip.ts#L570

  var tag = 'depth' in tags[j] ?
    tags[j] : <any>loaderInfo._file.getParsedTag(tags[j]);
  switch (tag.code) {

In SWFFile, controlTags are defined as UnparsedTag[] which does not match the logic above.

Introduced by https://github.com/mozilla/shumway/commit/8b5616ca41b66ab5d8ddf36b961cfaebacd55cd1
needinfo for Tobias.
Flags: needinfo?(schneider)
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Updated

3 years ago
Blocks: 1037580
Blocks: 1140984
No longer blocks: 1037580
(Assignee)

Updated

2 years ago
Product: Firefox → Firefox Graveyard
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
Flags: needinfo?(tschneider)
You need to log in before you can comment on or make changes to this bug.