Closed Bug 1119332 Opened 9 years ago Closed 8 years ago

Refactor controlTags logic to be in sync with SWFFile definition

Categories

(Firefox Graveyard :: Shumway, defect)

Product:
Firefox Graveyard
Component:
Shumway
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: yury, Unassigned)

References

Details

(Keywords: regression) 

Currently we have https://github.com/yurydelendik/shumway/blob/8b5616ca41b66ab5d8ddf36b961cfaebacd55cd1/src/flash/display/MovieClip.ts#L570

  var tag = 'depth' in tags[j] ?
    tags[j] : <any>loaderInfo._file.getParsedTag(tags[j]);
  switch (tag.code) {

In SWFFile, controlTags are defined as UnparsedTag[] which does not match the logic above.

Introduced by https://github.com/mozilla/shumway/commit/8b5616ca41b66ab5d8ddf36b961cfaebacd55cd1
needinfo for Tobias.
Flags: needinfo?(schneider)
OS: Mac OS X → All
Hardware: x86 → All
No longer blocks: shumway-m4
Product: Firefox → Firefox Graveyard
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Flags: needinfo?(tschneider)
You need to log in before you can comment on or make changes to this bug.