1119337 - make retry() output more readable

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Massimo Gervasini [:massimo]]

Attachment: [tools] make retry() output more readable.patch

Follow up of https://bugzilla.mozilla.org/show_bug.cgi?id=701099#c4

A simple change, retry should print the "action.__name__" instead of "action" 

So that we have log messages like this:

retry: Calling rmtree with args: ('/Users/mgerva/work/git/build/mozharness/build',), kwargs: {}, attempt #1

instead of:
retry: Calling <function rmtree at 0x100645050> with args: ('/Users/mgerva/work/git/build/mozharness/build',), kwargs: {}, attempt #1

Comment 1

[Massimo Gervasini [:massimo]]

Attachment: [mozharness] Bug 1119337 - improve log output of retry, and some consumers of it - make retry output more readable.patch

Just for the record, r+ from bhearsum here: https://bugzilla.mozilla.org/show_bug.cgi?id=701099#c4

Comment 2

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8546010 [details] [diff] [review]
[tools] make retry() output more readable.patch

Review of attachment 8546010 [details] [diff] [review]:
-----------------------------------------------------------------

awesome, big improvement!

Comment 3

[Massimo Gervasini [:massimo]]

Comment on attachment 8546010 [details] [diff] [review]
[tools] make retry() output more readable.patch

Thanks pete!

Comment 4

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/mozharness/rev/70550db540e8