701099 - improve log output of retry, and some consumers of it

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P3)

Description

[[e-mail] (:bhearsum)]

We hit an issue today where tagging was failing and it was difficult to figure out why because the exception were being swallowed. We should stop doing that in a few places:
* retry.py - print exceptions as soon as they are caught: http://hg.mozilla.org/build/tools/file/7bdc98b0ec97/lib/python/util/retry.py#l27
* tag-release.py: http://hg.mozilla.org/build/tools/file/tip/scripts/release/tag-release.py#l80 and http://hg.mozilla.org/build/tools/file/tip/scripts/release/tag-release.py#l102

And possibly other places.

Comment 1

[[e-mail] (:bhearsum)]

Mass move of bugs to Release Automation component.

Comment 2

[[e-mail] (:bhearsum)]

retry.py prints exceptions immediately now: https://github.com/mozilla/build-tools/blob/master/lib/python/util/retry.py#L33, and raises them to the caller: https://github.com/mozilla/build-tools/blob/master/lib/python/util/retry.py#L36

tag-release.py still eats some exceptions, though.

Comment 3

[Massimo Gervasini [:massimo]]

Attachment: [mozharness] Bug 701099 - improve log output of retry, and some consumers of it - make retry output more readable.patch

Just a small change, it will ouput:

retry: Calling rmtree with args: ('/Users/mgerva/work/git/build/mozharness/build',), kwargs: {}, attempt #1

instead of:
retry: Calling <function rmtree at 0x100645050> with args: ('/Users/mgerva/work/git/build/mozharness/build',), kwargs: {}, attempt #1

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8545976 [details] [diff] [review]
[mozharness] Bug 701099 - improve log output of retry, and some consumers of it - make retry output more readable.patch

Review of attachment 8545976 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't really address this bug, but it seems good. Please update the tools version too.

Comment 5

[Massimo Gervasini [:massimo]]

Thanks bhearsum, I have created bug 1119337 to track this improvement.

Comment 6

[Massimo Gervasini [:massimo]]

Comment on attachment 8545976 [details] [diff] [review]
[mozharness] Bug 701099 - improve log output of retry, and some consumers of it - make retry output more readable.patch

moved to bug 1119337