1119363 - Intermittent test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

04:01:24 INFO - 1516 INFO TEST-START | js/xpconnect/tests/chrome/test_bug732665.xul
04:01:24 INFO - 1517 INFO TEST-PASS | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be able to have at least 10 heavy frames more stack than content: 80, 69
04:01:24 INFO - 1518 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
04:01:24 INFO - 1519 INFO MEMORY STAT vsize after test: 1080451072
04:01:24 INFO - 1520 INFO MEMORY STAT vsizeMaxContiguous after test: 8519033622528
04:01:24 INFO - 1521 INFO MEMORY STAT residentFast after test: 360374272
04:01:24 INFO - 1522 INFO MEMORY STAT heapAllocated after test: 107745478
04:01:24 INFO - 1523 INFO TEST-OK | js/xpconnect/tests/chrome/test_bug732665.xul | took 38ms

Comment 1

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-08T10:09:17
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-inbound&job_id=5199108
repository: mozilla-inbound
who: rvandermeulen[at]mozilla[dot]com
machine: t-w864-ix-131
buildname: Windows 8 64-bit mozilla-inbound pgo test mochitest-other
revision: 2880e05d5e32

1518 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 2

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-15T17:46:25
log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=891820
repository: mozilla-central
who: wkocher[at]mozilla[dot]com
machine: t-w864-ix-147
buildname: Windows 8 64-bit mozilla-central pgo test mochitest-other
revision: 89a190592267

1518 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 3

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-15T19:04:00
log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1706568
repository: fx-team
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-076
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: cbdda39e8e5a

1518 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 4

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-16T03:17:09
log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=5539647
repository: mozilla-inbound
who: tomcat[at]mozilla[dot]com
machine: t-w864-ix-164
buildname: Windows 8 64-bit mozilla-inbound pgo test mochitest-other
revision: 0c2393315416

1519 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be able to have at least 10 heavy frames more stack than content: 70, 61 - expected PASS
1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 9 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 5

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-19T05:37:23
log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=5619644
repository: mozilla-inbound
who: tomcat[at]mozilla[dot]com
machine: t-w864-ix-103
buildname: Windows 8 64-bit mozilla-inbound pgo test mochitest-other
revision: 837613fc3a49

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 6

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-19T05:37:28
log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=5619935
repository: mozilla-inbound
who: tomcat[at]mozilla[dot]com
machine: t-w864-ix-070
buildname: Windows 8 64-bit mozilla-inbound pgo test mochitest-other
revision: 837613fc3a49

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 7

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-19T06:12:48
log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=5620824
repository: mozilla-inbound
who: tomcat[at]mozilla[dot]com
machine: t-w864-ix-115
buildname: Windows 8 64-bit mozilla-inbound pgo test mochitest-other
revision: 837613fc3a49

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 8

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-19T06:13:10
log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=5620825
repository: mozilla-inbound
who: tomcat[at]mozilla[dot]com
machine: t-w864-ix-063
buildname: Windows 8 64-bit mozilla-inbound pgo test mochitest-other
revision: 837613fc3a49

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 9

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=907382
repository: mozilla-central
start_time: 2015-01-19T10:50:15
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-091
buildname: Windows 8 64-bit mozilla-central pgo test mochitest-other
revision: dcb4c5573aef

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1732656
repository: fx-team
start_time: 2015-01-19T12:15:03
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-121
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: fc735ea14f19

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1733828
repository: fx-team
start_time: 2015-01-19T15:09:03
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-049
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: ab08515b732f

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1734597
repository: fx-team
start_time: 2015-01-19T17:57:02
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-127
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: 121f46041aba

1519 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be able to have at least 10 heavy frames more stack than content: 70, 61 - expected PASS
1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 9 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1735535
repository: fx-team
start_time: 2015-01-19T20:56:26
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-053
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: 739b6d124285

1519 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be able to have at least 10 heavy frames more stack than content: 70, 61 - expected PASS
1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 14

[Bobby Holley (:bholley)]

This means that the stack limits in XPCJSRuntime.cpp need to be adjusted.

I recall shu being interested in this code - shu, do you have a few cycles to do something intelligently here?

Comment 15

[Shu-yu Guo [:shu]]

Not this week, but I'll put it on my queue of things to look at.

Comment 16

[Bobby Holley (:bholley)]

Thanks shu.

Comment 17

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=5688661
repository: mozilla-inbound
start_time: 2015-01-20T17:52:09
who: rvandermeulen[at]mozilla[dot]com
machine: t-w864-ix-001
buildname: Windows 8 64-bit mozilla-inbound pgo test mochitest-other
revision: 084810ea6887

1519 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be able to have at least 10 heavy frames more stack than content: 70, 61 - expected PASS
1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 18

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1217945
repository: b2g-inbound
start_time: 2015-01-23T15:11:06
who: wkocher[at]mozilla[dot]com
machine: t-w864-ix-164
buildname: Windows 8 64-bit b2g-inbound pgo test mochitest-other
revision: a00dc33a5611

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 9 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 19

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1218207
repository: b2g-inbound
start_time: 2015-01-23T18:22:12
who: wkocher[at]mozilla[dot]com
machine: t-w864-ix-087
buildname: Windows 8 64-bit b2g-inbound pgo test mochitest-other
revision: 63f2263c23ef

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 9 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 20

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=932343
repository: mozilla-central
start_time: 2015-01-23T19:58:06
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-156
buildname: Windows 8 64-bit mozilla-central pgo test mochitest-other
revision: a00dc33a5611

1520 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 21

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=932485
repository: mozilla-central
start_time: 2015-01-23T22:22:06
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-041
buildname: Windows 8 64-bit mozilla-central pgo test mochitest-other
revision: c0f88b376e33

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 22

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=933748
repository: mozilla-central
start_time: 2015-01-24T06:29:06
who: rvandermeulen[at]mozilla[dot]com
machine: t-w864-ix-017
buildname: Windows 8 64-bit mozilla-central pgo test mochitest-other
revision: c0f88b376e33

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 23

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1219284
repository: b2g-inbound
start_time: 2015-01-24T05:48:08
who: rvandermeulen[at]mozilla[dot]com
machine: t-w864-ix-031
buildname: Windows 8 64-bit b2g-inbound pgo test mochitest-other
revision: 48d1185486e2

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 24

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1219068
repository: b2g-inbound
start_time: 2015-01-24T03:06:17
who: rvandermeulen[at]mozilla[dot]com
machine: t-w864-ix-009
buildname: Windows 8 64-bit b2g-inbound pgo test mochitest-other
revision: ab8d710d2470

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 25

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1784002
repository: fx-team
start_time: 2015-01-24T05:36:00
who: rvandermeulen[at]mozilla[dot]com
machine: t-w864-ix-041
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: bb70f0e4a567

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 9 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 26

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1783802
repository: fx-team
start_time: 2015-01-24T02:55:08
who: rvandermeulen[at]mozilla[dot]com
machine: t-w864-ix-045
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: 40079e3249d1

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 9 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 27

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=933974
repository: mozilla-central
start_time: 2015-01-24T07:22:06
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-125
buildname: Windows 8 64-bit mozilla-central pgo test mochitest-other
revision: cc5ae255af1c

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 28

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1219569
repository: b2g-inbound
start_time: 2015-01-24T09:15:12
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-120
buildname: Windows 8 64-bit b2g-inbound pgo test mochitest-other
revision: b466debb12cc

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 29

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1785596
repository: fx-team
start_time: 2015-01-24T12:06:21
who: philringnalda[at]gmail[dot]com
machine: t-w864-ix-049
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: 7e64e2068d8a

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 10 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 30

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1794174
repository: fx-team
start_time: 2015-01-26T08:47:09
who: rvandermeulen[at]mozilla[dot]com
machine: t-w864-ix-022
buildname: Windows 8 64-bit fx-team pgo test mochitest-other
revision: d34e894a9ea2

1558 INFO TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_bug732665.xul | Chrome should be invokable from content script with an exhausted stack: 9 - expected PASS
Return code: 1
Return code: 1
Return code: 1

Comment 31

[Shu-yu Guo [:shu]]

Trying 140k instead of the current 120k:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=348274581561

Comment 32

[Shu-yu Guo [:shu]]

Attachment: Tweak trusted stack buffer to give Win64 PGO more room.

Not sure what else is there to be done here. See the try push in comment 31. I
forced PGO by adding mk_add_options MOZ_PGO=1.

The opt m-oth tests are all green, and the intermittent oranges in the debug
seem unrelated to stack exhaustion.

Comment 33

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fe0a5e20d1f4

Comment 34

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 35

[Shu-yu Guo [:shu]]

Comment on attachment 8555473 [details] [diff] [review]
Tweak trusted stack buffer to give Win64 PGO more room.

Approval Request Comment
[Feature/regressing bug #]: No clue.
[User impact if declined]: Inability to call back into some chrome code when stack is exhausted.
[Describe test coverage new/current, TreeHerder]: On central.
[Risks and why]: Low. Lowers the amount of content-usable stack space on Win64, but that number is already different on each platform so nobody should depend on it.
[String/UUID change made/needed]: None.

Comment 36

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8555473 [details] [diff] [review]
Tweak trusted stack buffer to give Win64 PGO more room.

Aurora+

Comment 37

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/220148363987