Closed
Bug 1119463
Opened 9 years ago
Closed 9 years ago
Expose MSE to youtube-nocookie.com
Categories
(Core :: Audio/Video, defect, P2)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: rillian, Assigned: rillian)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
2.04 KB,
patch
|
rillian
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In review of bug 1112761, I noticed youtube embeds are sometimes served from www.youtube-nocookie.com. We should probably add that to the list controlled by media.mediasource.youtubeonly.
Assignee | ||
Comment 1•9 years ago
|
||
Proposed update.
Assignee: nobody → giles
Attachment #8546133 -
Flags: review?(kinetik)
Assignee | ||
Comment 2•9 years ago
|
||
Fix warning by adding parentheses.
Attachment #8546133 -
Attachment is obsolete: true
Attachment #8546133 -
Flags: review?(kinetik)
Attachment #8546135 -
Flags: review?(kinetik)
Comment 3•9 years ago
|
||
Comment on attachment 8546135 [details] [diff] [review] Enable MSE for youtube-nocookie.com v2 I was going to say this for the original review, but it didn't seem to matter as much for a single test. Since we're adding one, and there's a chance we'll have to add more, I think it'd be slightly nicer if it was: if (NS_FAILED(tldServ->GetBaseDomain(uri, 0, eTLDplusOne))) { return false; } return eTLDplusOne.EqualsLiteral("youtube.com") || eTLDplusOne.EqualsLiteral("youtube-nocookie.com");
Attachment #8546135 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Reformat as suggested. Carrying forward r=kinetik.
Attachment #8546135 -
Attachment is obsolete: true
Attachment #8546260 -
Flags: review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/901e53fd2486
status-firefox36:
--- → unaffected
status-firefox37:
--- → affected
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8546260 [details] [diff] [review] Enable MSE for youtube-nocookie.com v3 Landed on Aurora with a=mse pre-approval. https://hg.mozilla.org/releases/mozilla-aurora/rev/3adeb981ced7 This is low risk, adding a second domain to the filter under media.mediasource.youtubeonly. MSE-specific.
Attachment #8546260 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8546260 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/901e53fd2486
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•