1119463 - Expose MSE to youtube-nocookie.com

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Ralph Giles (:rillian)]

In review of bug 1112761, I noticed youtube embeds are sometimes served from www.youtube-nocookie.com. We should probably add that to the list controlled by media.mediasource.youtubeonly.

Comment 1

[Ralph Giles (:rillian)]

Attachment: 0001-Bug-1119463-Enable-MSE-for-youtube-nocookie.com.-r-k.patch

Proposed update.

Comment 2

[Ralph Giles (:rillian)]

Attachment: Enable MSE for youtube-nocookie.com v2

Fix warning by adding parentheses.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8546135 [details] [diff] [review]
Enable MSE for youtube-nocookie.com v2

I was going to say this for the original review, but it didn't seem to matter as much for a single test.  Since we're adding one, and there's a chance we'll have to add more, I think it'd be slightly nicer if it was:

    if (NS_FAILED(tldServ->GetBaseDomain(uri, 0, eTLDplusOne))) {
      return false;
    }

    return eTLDplusOne.EqualsLiteral("youtube.com") ||
           eTLDplusOne.EqualsLiteral("youtube-nocookie.com");

Comment 4

[Ralph Giles (:rillian)]

Attachment: Enable MSE for youtube-nocookie.com v3

Reformat as suggested. Carrying forward r=kinetik.

Comment 5

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/901e53fd2486

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8546260 [details] [diff] [review]
Enable MSE for youtube-nocookie.com v3

Landed on Aurora with a=mse pre-approval.

https://hg.mozilla.org/releases/mozilla-aurora/rev/3adeb981ced7

This is low risk, adding a second domain to the filter under media.mediasource.youtubeonly. MSE-specific.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/901e53fd2486