Expose MSE to youtube-nocookie.com

RESOLVED FIXED in Firefox 36

Status

()

P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

(Blocks: 1 bug)

Trunk
mozilla37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

In review of bug 1112761, I noticed youtube embeds are sometimes served from www.youtube-nocookie.com. We should probably add that to the list controlled by media.mediasource.youtubeonly.
Proposed update.
Assignee: nobody → giles
Attachment #8546133 - Flags: review?(kinetik)
Fix warning by adding parentheses.
Attachment #8546133 - Attachment is obsolete: true
Attachment #8546133 - Flags: review?(kinetik)
Attachment #8546135 - Flags: review?(kinetik)
Comment on attachment 8546135 [details] [diff] [review]
Enable MSE for youtube-nocookie.com v2

I was going to say this for the original review, but it didn't seem to matter as much for a single test.  Since we're adding one, and there's a chance we'll have to add more, I think it'd be slightly nicer if it was:

    if (NS_FAILED(tldServ->GetBaseDomain(uri, 0, eTLDplusOne))) {
      return false;
    }

    return eTLDplusOne.EqualsLiteral("youtube.com") ||
           eTLDplusOne.EqualsLiteral("youtube-nocookie.com");
Attachment #8546135 - Flags: review?(kinetik) → review+
Reformat as suggested. Carrying forward r=kinetik.
Attachment #8546135 - Attachment is obsolete: true
Attachment #8546260 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/901e53fd2486
status-firefox36: --- → unaffected
status-firefox37: --- → affected
status-firefox36: unaffected → affected
Comment on attachment 8546260 [details] [diff] [review]
Enable MSE for youtube-nocookie.com v3

Landed on Aurora with a=mse pre-approval.

https://hg.mozilla.org/releases/mozilla-aurora/rev/3adeb981ced7

This is low risk, adding a second domain to the filter under media.mediasource.youtubeonly. MSE-specific.
Attachment #8546260 - Flags: approval-mozilla-aurora?
status-firefox36: affected → fixed
Blocks: 1119691
Attachment #8546260 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/901e53fd2486
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
status-firefox37: affected → fixed
You need to log in before you can comment on or make changes to this bug.