Closed Bug 1119691 Opened 5 years ago Closed 5 years ago

Build bustage in dom/media/mediasource/MediaSource.cpp

Categories

(Core :: Audio/Video, defect, major)

x86_64
Gonk (Firefox OS)
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 + fixed
firefox37 --- fixed

People

(Reporter: seinlin, Assigned: seinlin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When I config and build nexus-5-l, I got the following compile error

--
In file included from objdir-gecko/dom/media/mediasource/Unified_cpp_media_mediasource0.cpp:11:0:

dom/media/mediasource/MediaSource.cpp: In static member function 'static bool mozilla::dom::MediaSource::Enabled(JSContext*, JSObject*)':

gecko/dom/media/mediasource/MediaSource.cpp:348:65: error: 'do_GetService' was not declared in this scope
     do_GetService(NS_EFFECTIVETLDSERVICE_CONTRACTID);
                                                                 ^
make[3]: *** [Unified_cpp_media_mediasource0.o] Error 1
Hi Boris, This patch can fix the compile error. Do you think if it is reasonable? Thanks!
Attachment #8546442 - Flags: feedback?(bzbarsky)
Blocks: MSE
Depends on: 1119463
Comment on attachment 8546442 [details] [diff] [review]
bug-1119691.patch

Ugh, unified builds.  Sorry about this.  :(

r=me
Attachment #8546442 - Flags: review+
Attachment #8546442 - Flags: feedback?(bzbarsky)
Attachment #8546442 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/0af503927b54
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8546442 [details] [diff] [review]
bug-1119691.patch

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Build will fail on non-unified/some tier-2 platforms.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Minimal, just adds a missing header include.
[String/UUID change made/needed]: None.
Attachment #8546442 - Flags: approval-mozilla-beta?
[Tracking Requested - why for this release]: Important for MSE feature code coherence.
Attachment #8546442 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Ralph Giles (:rillian) from comment #3)
> Taking the liberty of pushing this.

Please take care to verify the correctness of the patch's commit information before pushing next time.

https://hg.mozilla.org/releases/mozilla-beta/rev/7edfdc36c3cf
Assignee: nobody → kli
You need to log in before you can comment on or make changes to this bug.