1119691 - Build bustage in dom/media/mediasource/MediaSource.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

When I config and build nexus-5-l, I got the following compile error

--
In file included from objdir-gecko/dom/media/mediasource/Unified_cpp_media_mediasource0.cpp:11:0:

dom/media/mediasource/MediaSource.cpp: In static member function 'static bool mozilla::dom::MediaSource::Enabled(JSContext*, JSObject*)':

gecko/dom/media/mediasource/MediaSource.cpp:348:65: error: 'do_GetService' was not declared in this scope
     do_GetService(NS_EFFECTIVETLDSERVICE_CONTRACTID);
                                                                 ^
make[3]: *** [Unified_cpp_media_mediasource0.o] Error 1

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-1119691.patch

Hi Boris, This patch can fix the compile error. Do you think if it is reasonable? Thanks!

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8546442 [details] [diff] [review]
bug-1119691.patch

Ugh, unified builds.  Sorry about this.  :(

r=me

Comment 3

[Ralph Giles (:rillian)]

Taking the liberty of pushing this. https://hg.mozilla.org/integration/mozilla-inbound/rev/0af503927b54

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0af503927b54

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8546442 [details] [diff] [review]
bug-1119691.patch

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Build will fail on non-unified/some tier-2 platforms.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Minimal, just adds a missing header include.
[String/UUID change made/needed]: None.

Comment 6

[Ralph Giles (:rillian)]

[Tracking Requested - why for this release]: Important for MSE feature code coherence.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ralph Giles (:rillian) from comment #3)
> Taking the liberty of pushing this.

Please take care to verify the correctness of the patch's commit information before pushing next time.

https://hg.mozilla.org/releases/mozilla-beta/rev/7edfdc36c3cf