Closed Bug 1119758 Opened 9 years ago Closed 9 years ago

Show a banner when a langpack is installed

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S4 (23jan)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: stas, Assigned: stas)

References

Details

Attachments

(1 file)

Pull request
46 bytes, text/x-github-pull-request
alive
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
When a langpack is installed, we want to show a special system banner with the following text:

  {{ langpack }} installed.  To enable it, go to Settings > Languages.
Blocks: 1107346
Alive already gave his f+ in bug 1107346 comment 14.  I'll attach a pull request shortly.
Attached file Pull request — 
Alive, does this need a test?  Are there any existing Marionette tests for the system banner?  I wasn't able to find any.
Assignee: nobody → stas
Status: NEW → ASSIGNED
Attachment #8546552 - Flags: review?(alive)
Comment on attachment 8546552 [details] [review]
Pull request

Yes, please at least have an unit test in app_install_manager_test.js, lemme know if you have problems doing that. Thanks!
Attachment #8546552 - Flags: review?(alive)
Comment on attachment 8546552 [details] [review]
Pull request

I added a unit test in https://github.com/stasm/gaia/commit/5298116981c5be1c6e5a4c63fbffec984419dc1c.  Can you take a look now, please?
Attachment #8546552 - Flags: review?(alive)
Comment on attachment 8546552 [details] [review]
Pull request

Great, remember to rebase the commits into one before merging, thanks.
Attachment #8546552 - Flags: review?(alive) → review+
Thanks, Alive.  Commits squashed, try is green:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=aab1d77a218e
Keywords: checkin-needed
Comment on attachment 8546552 [details] [review]
Pull request

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #):  langpacks for 2.2 (tracking bug 1107341 and front-end dependencies in bug 1107346)

[User impact] if declined:  no instruction for the user explaining how to enable a newly installed langpack 

[Testing completed]:  manual on the device;  unit test

[Risk to taking this patch] (and alternatives if risky):  low

[String changes made]:  1 new string, langpack-install-success
Attachment #8546552 - Flags: approval-gaia-v2.2?
waiting for master landing before considering branch uplift.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8546552 [details] [review]
Pull request

Re-requesting 2.2 approval.

[Bug caused by] (feature/regressing bug #):  langpacks for 2.2 (tracking bug 1107341 and front-end dependencies in bug 1107346)

[User impact] if declined:  no instruction for the user explaining how to enable a newly installed langpack 

[Testing completed]:  manual on the device;  unit test

[Risk to taking this patch] (and alternatives if risky):  low

[String changes made]:  1 new string, langpack-install-success
Attachment #8546552 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2?(bbajaj)
status-b2g-v2.2: --- → affected
status-b2g-master: --- → fixed
Keywords: checkin-needed
Target Milestone: --- → 2.2 S4 (23jan)
Attachment #8546552 - Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: