1119899 - Please sign the distribution directory fix and partner-build-search hotfix xpi (v20150106.01)

Status: RESOLVED FIXED

Description

[Robert Strong [:rstrong] (use needinfo to contact me)]

To generate the XPI, do the following:

hg clone https://hg.mozilla.org/releases/firefox-hotfixes
cd firefox-hotfixes
HOTFIX=v20150106.01 make package

Then we need to sign the xpi generated at build/hotfix-v20150106.01.xpi

This hot fix will need to be distributed to the first version of Firefox that supported the hotfix (Firefox 11?) through the latest Firefox version similar to the v20140527.01 so it will need to be signed by the appropriate hotfix certificates for those versions, etc.

Comment 1

[Ben Hearsum (:bhearsum)]

Created attachment 8546840 [details]
signed hotfix

Per IRC, here's the hotfix signed with the most recent cert.

Comment 2

[Robert Strong [:rstrong] (use needinfo to contact me)]

Created attachment 8546900 [details]
unsigned hotfix

Comment 3

[Robert Strong [:rstrong] (use needinfo to contact me)]

Ben, I finally got my Mac to boot and found a bug in the code. Could you sign the hotfix I just attached? Thanks!

Comment 4

[Ben Hearsum (:bhearsum)]

Created attachment 8547563 [details]
signed hotfix, v2

Here you go.

Comment 5

[Robert Strong [:rstrong] (use needinfo to contact me)]

I did basic testing of the hotfix and all looks good so reassigning to :jorgev to upload to addons-dev.allizom.org and to publish it for testing per
https://wiki.mozilla.org/Firefox/Hotfix

Comment 6

[Jorge Villalobos [:jorgev]]

This hasn't been announced on release-drivers (step 1) yet, has it?

Comment 7

[Robert Strong [:rstrong] (use needinfo to contact me)]

It has and lmandel gave reldriver approval.

Comment 8

[Robert Strong [:rstrong] (use needinfo to contact me)]

Subject:
"Intent to ship: hotfix to fix distribution directory location (1113222) and partner distribution search engine (1110307)"

Body:
"I noticed that the steps at https://wiki.mozilla.org/Firefox/Hotfix don't include sign-off from release drivers, which I expected to see. We should review the steps to ensure that they are complete.

For this hotfix, I do approve its publication on behalf of release drivers once QE has signed off."

Are you good to publish the hotfix for testing?

Comment 9

[Robert Strong [:rstrong] (use needinfo to contact me)]

Note: the above was from lmandel

Comment 10

[Jorge Villalobos [:jorgev]]

I don't see the message on the list, but approval from lmandel is sufficient for staging. We need to make sure about timing for production deployment, since the last hotfix (bug 1110307) has only been up for a week.

The signed file is now staged. Rail, please test.

Comment 11

[Robert Strong [:rstrong] (use needinfo to contact me)]

Note: this hotfix contains the previous week's hotfix as well so timing should not be an issue.

Strange, the email and the reply from lmandel went to release-drivers and moc on Jan 9th

Comment 12

[Robert Strong [:rstrong] (use needinfo to contact me)]

Reassigning to Rail per https://wiki.mozilla.org/Firefox/Hotfix

Comment 13

[Rail Aliiev [:rail] ⌚️ET]

(In reply to Jorge Villalobos [:jorgev] from comment #10)
> I don't see the message on the list, but approval from lmandel is sufficient
> for staging. We need to make sure about timing for production deployment,
> since the last hotfix (bug 1110307) has only been up for a week.
> 
> The signed file is now staged. Rail, please test.

This should be assigned to someone from QE, I believe.

Comment 14

[Robert Strong [:rstrong] (use needinfo to contact me)]

Kamil, could you verify the hotfix works as expected? On Mac OS X it copies the distribution directory if it exists from Contents/MacOS/distribution/ to Contents/Resources/distribution/ if the destination does not exist. It also applies the hotfix in bug 1110307 which Felipe should be able to provide details about.

Comment 15

[Kamil Jozwiak [:kjozwiak]]

Used the following verification process: (went through this process 5 different times)

* Downloaded https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/33.1-candidates/build1/partner-repacks/aol/
* Once downloaded/installed, updated the browser to fx 35.0
* Used the following instructions to apply hotfix: https://developer.mozilla.org/en-US/Add-ons/Hotfix#Testing_the_hotfix_on_the_staging_server

Before the HOTFIX:

Once I updated fx, the default search engine was set as "Yahoo"

* browser.search.order.1;Google
* browser.search.order.US.1;data:text/plain,browser.search.order.US.1=Yahoo
* distribution.id -> missing
* distribution.about -> missing
* distribution.version -> missing

The distribution directory only appeared under the following location: 
* Contents/MacOS/distribution/

After the HOTFIX was applied:

After applying the hotfix, the default search engine appeared as "AOL"

* browser.search.order.1;data:text/plain,browser.search.order.1=AOL Search
* browser.search.order.US.1;data:text/plain,browser.search.order.US.1=Yahoo
* distribution.id;aol
* distribution.about;Mozilla Firefox with AOL Toolbar
* distribution.version;2.2
* browser.hotfix.v20150106.applied;true
* extensions.hotfix.lastVersion;20150106.01

The distribution directory appeared under the following locations:
* Contents/MacOS/distribution/
* Contents/Resources/distribution/

I also checked the browser console and ensured there wasn't any errors appearing during/after the update.

Robert, here are some possible issues:

* once the hotfix is applied, Yahoo still appears as the default search engine until fx has been restarted
* the distribution folder still appears under "Contents/MacOS/" after the hotfix, not sure if it should have been removed

Other than that, looks like everything is working correctly. Let me know if I missed something!

Comment 16

[Robert Strong [:rstrong] (use needinfo to contact me)]

Thanks Kamil!

(In reply to Kamil Jozwiak [:kjozwiak] from comment #15)
>...
> Robert, here are some possible issues:
> 
> * once the hotfix is applied, Yahoo still appears as the default search
> engine until fx has been restarted
That is expected and there is nothing that can be done about it. This is mitigated by the hotfix being delivered to earlier versions of Firefox so the distribution directory will already be in place prior to the update and will be read from after the update.

> * the distribution folder still appears under "Contents/MacOS/" after the
> hotfix, not sure if it should have been removed
This will be removed on the update after getting an update that includes the mac v2 signing code.

Comment 17

[Robert Strong [:rstrong] (use needinfo to contact me)]

Jorge, can you perform the final deployment?
https://wiki.mozilla.org/Firefox/Hotfix item 9

Comment 18

[Robert Strong [:rstrong] (use needinfo to contact me)]

Jorge ^^

Comment 19

[Jorge Villalobos [:jorgev]]

The new version of the hotfix is now live.