Closed Bug 1119932 Opened 6 years ago Closed 6 years ago

Flatten recursion in the flamegraph for the new performance tool

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 38

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

v1
11.47 KB, patch
jsantell
: review+
Details | Diff | Splinter Review 
No description provided.
Blocks: perf-tool-v2
OS: Mac OS X → All
Hardware: x86 → All
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attached patch v1 — — Splinter Review
Attachment #8547669 - Flags: review?(jsantell)
Comment on attachment 8547669 [details] [diff] [review]
v1

Review of attachment 8547669 [details] [diff] [review]:
-----------------------------------------------------------------

Is this going to be an option available to toggle from the UI? Is this something we always want on, probably?
Attachment #8547669 - Flags: review?(jsantell) → review+
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> Comment on attachment 8547669 [details] [diff] [review]
> v1
> 
> Review of attachment 8547669 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is this going to be an option available to toggle from the UI? Is this
> something we always want on, probably?

See https://bugzilla.mozilla.org/show_bug.cgi?id=1119934#c3
https://hg.mozilla.org/mozilla-central/rev/b8b515f7197b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.