1120147 - Allow importing Cleopatra profiler format

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: profile_0_13009.json

Trying to profile the startup of Firefox for Android can be impossible using the Remote Debugging UI. Jim Chen showed me how to launch Fennec using ADB with the profiler running. His command sleeps for 10 seconds (allowing Fennec to start) then it kills Fennec, triggering a "save profile to the SD card" action.

I am unable to import the JSON profile into Desktop's profiler UI. I pick the file and nothing happens. I'll attach the file.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Her is the command Jim gave me:

adb shell am start -n org.mozilla.fennec_mfinkle/.App -d google.com --es env0 MOZ_PROFILER_STARTUP=1; sleep 10; (adb shell ps | grep fennec_mfinkle | head -n1 | awk '{print $2}' | xargs adb shell su -c kill -12)

This starts fennec with profiling, loads a page, waits 10 seconds and then sends signal 12, which is SIGUSR2 aka "save profile to disk". The profile should be save at /sdcard/profile_*.txt (or /mnt/sdcard/profile_*.txt)

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The desktop profiler does not appear to understand profiles generated outside of its own UI.

It looks for a special |fileType| key in the JSON, which your does not have.

However, you can import your file into Cleopatra / Gecko Profile add-on, which appears to work.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to J. Ryan Stinnett [:jryans] from comment #2)
> The desktop profiler does not appear to understand profiles generated
> outside of its own UI.
> 
> It looks for a special |fileType| key in the JSON, which your does not have.

Can we fix that somehow?

> However, you can import your file into Cleopatra / Gecko Profile add-on,
> which appears to work.

Yes, this seems to work! Thanks for the workaround!

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Victor, i(In reply to Mark Finkle (:mfinkle) from comment #3)
> (In reply to J. Ryan Stinnett [:jryans] from comment #2)
> > The desktop profiler does not appear to understand profiles generated
> > outside of its own UI.
> > 
> > It looks for a special |fileType| key in the JSON, which your does not have.
> 
> Can we fix that somehow?

Victor, is it possible for the toolbox profiler to consume these more general profile recordings?

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to J. Ryan Stinnett [:jryans] from comment #4)
> 
> Victor, is it possible for the toolbox profiler to consume these more
> general profile recordings?

The profiles saved by cleopatra have a different format than the ones saved by devtools. When the new performance panel lands, this is going to be exacerbated by the additional timeline information added to them.

Having said that, it's still possible to adapt our importer to handle the addon's format, with the caveat that a lot of information will be missing (re: timeline).

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Victor Porof [:vporof][:vp] from comment #5)
> (In reply to J. Ryan Stinnett [:jryans] from comment #4)
> > 
> > Victor, is it possible for the toolbox profiler to consume these more
> > general profile recordings?
> 
> The profiles saved by cleopatra have a different format than the ones saved
> by devtools. When the new performance panel lands, this is going to be
> exacerbated by the additional timeline information added to them.
> 
> Having said that, it's still possible to adapt our importer to handle the
> addon's format, with the caveat that a lot of information will be missing
> (re: timeline).

Okay, I've renamed this bug to add such importing support at some future time.

Comment 7

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 8

[Greg Tatum [:gregtatum]]

Perf.html does this, so we WONTFIX this because of Bug 1408124.