1120315 - Notify tag/peer lost when app is switched to background

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Dimi Lee [ooo Mar. 28 - Apr. 6]]

If an app registers ontagfound then it will receive notification when device touch a NFC tag. But if this app is switch to background for some reason, gecko should sent the app "taglost" notification.

Comment 1

[Dimi Lee [ooo Mar. 28 - Apr. 6]]

Should we send taglost if an APP has registered ontagfound but he cannot handle previous tagfound notification ?

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This should be a follow-up for Bug 1082445, now we have a Browser API for NFC, so we should use the API to notify taglost/peerlost, instead of listening to visibilitychange.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: revert Bug 1082445

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: rename to changed.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: notify tag/peerlost when losing focus.

Comment 6

[Dimi Lee [ooo Mar. 28 - Apr. 6]]

Comment on attachment 8554478 [details] [diff] [review]
Part 3: notify tag/peerlost when losing focus.

Review of attachment 8554478 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/gonk/Nfc.js
@@ +176,5 @@
>        target.sendAsyncMessage("NFC:DOMEvent", options);
>      },
>  
>      setFocusApp: function setFocusApp(id, isFocus) {
> +      if (this.focusApp != NFC.SYSTEM_APP_ID) {

missing |!isFocus| ?

checked with alive before, the UI behavior when changing focus app may look likes

1.setFocusApp(id of previous app, false);
2.setFocusApp(id of new app, true);  --> may send this once or twice

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: notify tag/peerlost when losing focus. v2.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: notify tag/peerlost when losing focus. v3.

Comment 9

[Dimi Lee [ooo Mar. 28 - Apr. 6]]

Comment on attachment 8555090 [details] [diff] [review]
Part 3: notify tag/peerlost when losing focus. v3.

Review of attachment 8555090 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 4: update comments in MozNFC.webidl

Hi, smaug
Can you help to review the comments updated in MozNFC.webidl?

Thanks

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d2c152107337
https://hg.mozilla.org/integration/b2g-inbound/rev/4152c86ec943
https://hg.mozilla.org/integration/b2g-inbound/rev/f97fb74d8120
https://hg.mozilla.org/integration/b2g-inbound/rev/3091c49631a2

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8554474 [details] [diff] [review]
Part 1: revert Bug 1082445

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1082445

User impact if declined: 
Possibly cannot receive NFC events.

Testing completed: 
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
No.

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8554477 [details] [diff] [review]
Part 2: rename to changed.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1082445

User impact if declined: 
Possibly cannot receive NFC event.

Testing completed: 
Manually

Risk to taking this patch (and alternatives if risky): 
No

String or UUID changes made by this patch:
Updated uuid in nsINfcContentHelper.idl, which is an internal IDL.

Comment 14

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8555090 [details] [diff] [review]
Part 3: notify tag/peerlost when losing focus. v3.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1082445

User impact if declined: 
Possibly cannot receive NFC event.

Testing completed: 
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
internal IDL - nsINfcContentHelper.idl.

Comment 15

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8555642 [details] [diff] [review]
Part 4: update comments in MozNFC.webidl

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]

Bug caused by (feature/regressing bug #): 
Bug 1082445

User impact if declined: 
No, this patch just updated documentation.

Testing completed: 
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
No.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4152c86ec943
https://hg.mozilla.org/mozilla-central/rev/f97fb74d8120
https://hg.mozilla.org/mozilla-central/rev/3091c49631a2

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cbcf1d1701a5
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/83890dca4ed7
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b16a74a70e57
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1ff75bfd605c