1120421 - Bug 1100399 inverted the meaning of the label of the "always ask this" checkbox but forgot to update the logic

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1100399 +++

Normally, I'd just back out, but this will merge to aurora today and because of the string changes, that's not feasible.

I guess it goes to show nobody reads prompts (including the people who change them or review them). :-(

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Ugh. Sorry for missing that. :/

Comment 2

[:Gijs (he/him)]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #1)
> Ugh. Sorry for missing that. :/

Not your fault, I should have written a better patch. :-(

Comment 3

[:Gijs (he/him)]

Attachment: checkbox value should match checkbox text,

This matches the previous dialog's checkbox's behaviour (checked by default, uncheck to stop the prompts

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8547610 [details] [diff] [review]
checkbox value should match checkbox text,

Review of attachment 8547610 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, Gijs.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8547610 [details] [diff] [review]
checkbox value should match checkbox text,

Review of attachment 8547610 [details] [diff] [review]:
-----------------------------------------------------------------

Er, that should have been an r+.

Comment 6

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/005a7c3f0fac

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/005a7c3f0fac

Comment 9

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 38.0a1, buildID: 20150115030228 (builds: en-US, pl).

Comment 10

[:Gijs (he/him)]

Comment on attachment 8547610 [details] [diff] [review]
checkbox value should match checkbox text,

Approval Request Comment
[Feature/regressing bug #]: bug 1086958
[User impact if declined]: Impacts default browser dialog on startup with the checkbox value and label not matching up
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: low
[String/UUID change made/needed]: no

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8547610 [details] [diff] [review]
checkbox value should match checkbox text,

Aurora+

Bug 1086958 landed in 34. Should we consider this fix for Beta 36 as well?

Comment 12

[:Gijs (he/him)]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #11)
> Comment on attachment 8547610 [details] [diff] [review]
> checkbox value should match checkbox text,
> 
> Aurora+
> 
> Bug 1086958 landed in 34. Should we consider this fix for Beta 36 as well?

Sorry, I copy/pasted the wrong regressing bug. This should have been bug 1100399, which only landed in 37.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7937c3fe4571

Comment 14

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Aurora 37.0a2, buildID: 20150121004011 (builds: en-US, pl).