1120577 - [Privacy Panel] Changing passphrase and entering wrong SIM PIN does NOT warn user of number of tries left before SIM will be locked

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: screenshot from Flame 2.2

Description:
If user enters a wrong SIM PIN in Privacy Panel's  'Change your passphrase' page, the page does NOT warn user of the number of tries left before SIM is locked.

Prerequisites:
Have a passphrase already set up via Settings > Privacy Panel > Remote Privacy Protection.

STR:
1) Go to Settings > Privacy Panel > Remote Privacy Protection > tap 'Forgot/Change your passphrase?'
2) Enter a wrong SIM PIN, enter new passphrase, and tap OK.

Expected: The error message should also include how many more attempts the user has before SIM is locked

Actual: The error message only says the SIM PIN is wrong. See attached screenshot.

Repro rate: 4/4

Tested on:
Device: Flame KK
BuildID: 20150112010228
Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko: bb8d6034f5f2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat on Flame 2.2

Attaching a logcat.

Comment 2

[Josh Cheng [:josh]]

Dear EJ,
This seems to be security issue. Could you help to check this when you have time?
Thanks!

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

@Josh,

This bug is related to Privacy Panel app instead (not Settings app).

I helped to check codebase and it's true that PP didn't handle this error from day one. So if this is urgent, maybe we should ask for some helps from PP. If not, I can help to take this.

But no matter how, we should ask for UI/UX's help first for this special case and see how to show/hide this kind of error for users. (I don't know who is the proper person that would take care of this design, please help to ni? the right person)

Thanks !!

Comment 4

[Josh Cheng [:josh]]

Thanks EJ!

Dear Marta,
Can you help to check this PP bug? Moreover do you know who is the UX owner of privacy app here?
Thanks!

Comment 5

[marta]

We had the initial r+ from Juwei, NI'ing her. I will work on it soon

Comment 6

[Josh Cheng [:josh]]

Dear Juwei,
Could you provide spec for correct behavior of what error message we should see here? Thanks!

Comment 7

[Juwei Huang[:juwei]]

Hi,
I agree that we should add the number of tries left.
I suggest that the string could be "X passcode attempts left"

Comment 8

[Josh Cheng [:josh]]

Dear Marta,
Can you check the comment from JuWei per comment 7 about expected behavior? Thanks!

Comment 9

[marta]

Hi,
I'm working on it. Funny enough my only problem right now is that I don't have a sim-card to test it. Attached is the proposed patch.

Comment 10

[marta]

Attachment: Bug_1120577.patch

proposed fix, not able to test it

Comment 11

[Fabien Cazenave [:kaze]]

taking

Comment 12

[Fabien Cazenave [:kaze]]

Attachment: pull request

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 8560203 [details] [review]
pull request

Looking good, can we get a basic unit test coverage?
(since this won't be easily integration-testable)

Comment 14

[Fabien Cazenave [:kaze]]

Comment on attachment 8560203 [details] [review]
pull request

PR updated with unit tests

Comment 15

[Etienne Segonzac (:etienne)]

Comment on attachment 8560203 [details] [review]
pull request

yep that'll do it :)

Comment 16

[Fabien Cazenave [:kaze]]

Thanks Étienne! Merged on master: https://github.com/mozilla-b2g/gaia/commit/6492bba

Comment 17

[Fabien Cazenave [:kaze]]

Comment on attachment 8560203 [details] [review]
pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): ?
[User impact] if declined: risk of locking the SIM card when changing the remote protection passphrase
[Testing completed]: unit tests + manual
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: one new string

Comment 18

[Francesco Lodolo [:flod]]

Even if unused in the code, can you please add all plural forms ([zero] included)? That makes external tools happy.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/b4426bb86163da611b6123379e4484d93c8cf80e

Comment 20

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest nightly build of Flame KK v2.2&2.5 by the STR in comment 0.

Actual results: Changing passphrase and entering wrong SIM PIN will prompt the number of tries left before SIM will be locked.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/6


Device: Flame KK 2.2 (Pass) 
Build ID               20150929032504
Gaia Revision          5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gaia Date              2015-09-21 11:20:23
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/65ddad73ad6b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150929.064906
Firmware Date          Tue Sep 29 06:49:17 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5 (Pass)
Build ID               20150929150202
Gaia Revision          f345f6a015709beeb2ca3955cab077fcaa959d3b
Gaia Date              2015-09-29 03:53:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccee6614fd9d18a31f263fbcfe9676b224d851aa
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150929.201052
Firmware Date          Tue Sep 29 20:11:01 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 21

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.png