1120704 - [Windows Management][Homescreen][ Returning to the homescreen from an app in landscape mode causes the bottom row of homescreen icons to be slightly cut-off on the bottom

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150112_1509.txt

Description:
When you are in an app in landscape mode and press the homescreen button you will be taken to the homescreen (in portrait) but the bottom row of icons are slightly cut-off. This is not permanent and there are a few ways to 'fix' it such as long pressing home to go to the task manager and then pressing home again to return to the homescreen. This occurs in 3 and 4 column homescreen.

Repro Steps: 
1) Update a Flame to 20150112010228
2) Launch an app that can be viewed in landscape mode (Video, Browser)
3) Turn device to view app in landscape mode
4) Tap homescreen button to return to homescreen
5) Scroll down to the bottom

Actual:
Bottom row of icons is cut-off

Expected:
Homescreen will maintain it's normal appearance and spacing. Icons and names will be easily readable.

Environmental Variables:
Device: Flame Master
Build ID: 20150112010228
Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko: bb8d6034f5f2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (Master)
Firmware Version: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Repro frequency: 4/4
See attached: logcat, screenshot

--------------------------------------------------------------------

This issue also repros on 2.2 (V188-1), 

Device: Flame Master (KK - nightly - full flash)
Build ID: 20150112010228
Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko: bb8d6034f5f2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (Master)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

---------------------------------------------------------------------------
This issue does NOT repro on 2.1 and 2.0

Device: Flame 2.1 (KK - nightly - full flash)
Build ID: 20150112001215
Gaia: 1975241ac29f723479e6c60b2bf74ebed54da91a
Gecko: 0863fe4b75c3
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 34.0 (2.1)
Firmware Version: V18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 (KK - nightly - full flash)
Build ID: 20150112000204
Gaia: 31d6c9422cd0a8213df9f96019c9ab7168ec3ab3
Gecko: a05a5378cb1f
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 32.0 (2.0)
Firmware Version: V18D
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 1

[Joshua Mitchell (Inactive)]

Attachment: HomescreenBottom.png

Comment 2

[Peter Bylenga [:PBylenga]]

regression of core feature.

Requesting a window.

Comment 3

[Yeojin Chung [:YeojinC]]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 2.2
BuildID: 20150106010241
Gaia: f2c5dcef558f747e525220f1dfb2da6b07325235
Gecko: 080bf51ff425
Version: 37.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

First Broken Environmental Variables:
Device: Flame 2.2
BuildID: 20150106023745
Gaia: 9f400639489276a01eda2f7c1536b2429e98a247
Gecko: c6251e0f5230
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 37.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Last Working Gaia First Broken Gecko: Issue NOT reproduce 
Gaia: f2c5dcef558f747e525220f1dfb2da6b07325235
Gecko: c6251e0f5230

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 9f400639489276a01eda2f7c1536b2429e98a247
Gecko: 080bf51ff425

https://github.com/mozilla-b2g/gaia/compare/f2c5dcef558f747e525220f1dfb2da6b07325235...9f400639489276a01eda2f7c1536b2429e98a247

caused by bug 1114800

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Etienne, could you please take a look at this issue? Looks like the landing for bug 1114800 may have caused this to occur.

Comment 5

[GitHub Autolander Bot]

Attachment: [PullReq] etiennesegonzac:bug-1120704 to mozilla-b2g:master

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8551840 [details] [review]
[PullReq] etiennesegonzac:bug-1120704 to mozilla-b2g:master

Glad we found that bug :)

Here's the deal, since the homescreen doesn't have an overlay we were never removing the homescreen's iframe inlined size.

*But* the real issue was that this size was incorrect (didn't take the statusbar into account). So I started by fixing this.
*But* I realized that if the sizing was incorrect we must have been reflowing stuff all along (since the inlined size was different from the original size).

Did some more investigation and turns out there's no way to prevent the reflow (since inlining the size will trigger one anyway), so yay code removal!

Comment 7

[Candice Serran (:cserran)]

incorrect ux, definitely a blocker

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8551840 [details] [review]
[PullReq] etiennesegonzac:bug-1120704 to mozilla-b2g:master

I like the *but*s!

FWIW after all these bugs I realized for 'orientationchange' we have no way but to change everyone's layout no matter it is background or foreground otherwise something bad may happen during transition or after the transition.

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f6631b519958601137830a7eb9e51f816bd75f20

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please request v2.2 approval on this when you get a chance.

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 8551840 [details] [review]
[PullReq] etiennesegonzac:bug-1120704 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): the original edge gesture support (old)

[User impact] if declined: in some cases the bottom 20px of an app can be outside of the viewport, inaccessible to the user.

[Testing completed]: the STR from the bug + general orientation change scenarios

[Risk to taking this patch] (and alternatives if risky): low (no new code)

[String changes made]: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/013fb2ffecb84b8837f6721d1d24f096cda44b57

Comment 13

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue has been verified as fixed on Flame 3.0

After viewing a video or web page in landscape mode and returning home, the user can scroll to the bottom of the homescreen without issue. No icons appear to be cut off.

Environmental Variables:
Device: Flame 3.0 (Full Flash)(KK)(319mb)
BuildID: 20150123010227
Gaia: cba2f0bf49b882e0044c3cc583de8fcf83d2ffa4
Gecko: 494632b9afed
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0