1120726 - [Privacy Panel][Remote Privacy Protection] RPP functions disable notifications on the lock screen without notifying the user.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-RPP-notifications-lockscreen.txt

Description:
If the user has Remote Privacy Protection set up on their device, using one of the RPP functions (locate, ring, or lock) will disable the 'Show on lock screen' Notification setting.  Neither the Guided Tour, nor the function description in the Privacy Panel inform the user that this will happen, and the previous settings are not restored after the user unlocks the device.
   
Repro Steps:
1) Update a Flame device to BuildID: 20150112010228
2) Navigate to Privacy Panel in Settings, and dismiss the complete the Guided Tour
3) Select Remote Privacy Protection and configure your passphrase.
4) Enable 'Remote Lock'
5) Navigate to Settings > Notifications and verify that 'Show on lock screen' is enabled
6) From another device, send 'RPP lock <PASSPHRASE>" in an SMS to the DUT
7) Unlock the DUT, and navigate back to Settings > Notifications
  
Actual:
'Show on lock screen' is disabled without notification to the user.
  
Expected: 
Device settings are not modified without notifying the user.
  
Environmental Variables:
Device: Flame KK
BuildID: 20150112010228
Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko: bb8d6034f5f2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (KK)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 8/8
See attached: video clip (URL), logcat

-------------------------------------------------------

Issue does NOT occur on Flame 2.1.
Privacy Panel was not implemented on this branch.

Environmental Variables:
Device: Flame 2.1
BuildID: 20150112001215
Gaia: 1975241ac29f723479e6c60b2bf74ebed54da91a
Gecko: 0863fe4b75c3
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 34.0 (2.1)
Firmware: V18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 1

[marta]

Attachment: Proposed patch

The same will be valid for Find My Device

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8552111 [details] [review]
Proposed patch

I didn't test this, but it's fairly simple and makes sense to me. Thanks!

Comment 3

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/4889d1400fbb2ac63d7d182d4637a542f0cd7026