1120745 - Add dolphin 512MB device to config.sh

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Dolphin device with 512MB memory use different hardware components. Need to add a specific device config for it.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Support dolphin512 in config.sh

Michael, Dolphin with 512MB Ram need to use different DEVICE and PRODUCT_NAME and it can use the same manifest as Dolphin with 256MB Ram. Could you review this patch? Thanks!

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Create a symbolic link for dolphin512.

Michael, I think create a symbolic as how emulator does should be ok. Could you review this patch? Thanks!

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: [v2.1s] Create a symbolic link for dolphin512.

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/B2G/commit/2118ac5c049e9dfe58766723fef45857fc63314a
https://github.com/mozilla-b2g/b2g-manifest/commit/8bcba38dc3c6baa66840c0974fdc92d418604900

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

v2.1s: https://github.com/mozilla-b2g/b2g-manifest/commit/106e31b0a0c5bb61c15f30b82d4d161ba06e995c

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

May be we'd like to add dolphin-512 device manifest into v2.2.

Comment 7

[Josh Cheng [:josh]]

Hi Steven,
Since it's possible to have 2.2S in the future. Can you triage whether this should be landed on 2.2? Thanks!

Comment 8

[Steven Yang [:styang]]

We'll also need the Dolphin build with 2.2 to track some issues such as performance. I'll give a plus to it.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please request b2g37 approval on this when you get a chance.

Also, from the sounds of it, we're going to want Dolphin-512 builds running on v2.2 as well? At that point, we should almost certainly be running them on master as well.

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

Now only dolphin is running on master, and I don't think we should also have dolphin-512 on master because monitoring the status on master with dolphin could be enough.

Dolphin-512 is running on v2.1s only. We can have Dolphin-512 manifest on v2.2, but we don't need to get Dolphin-512 builds on v2.2 at this moment.

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/8bcba38dc3c6baa66840c0974fdc92d418604900