Closed Bug 1120777 Opened 7 years ago Closed 7 years ago

Make OpenSearch queries open in the user's default browser

Categories

(Thunderbird :: Search, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 38.0

People

(Reporter: squib, Assigned: squib)

References

Details

(Keywords: relnote)

Attachments

(1 file)

Thunderbird's web search tab stinks. A lot. There are numerous problems with it, including the lack of a URL bar, horrible accessibility, and just general ugliness, to name a few. Of all the code I've ever landed in comm-central, I think the web search tab is probably the worst.

I really think that trying to embed a good (or even decent!) browser is way out of scope for Thunderbird. For the users who really want such a thing, Thunderbrowse is far better than what we have now, and our time can be better spent elsewhere, like on email. ;)

This patch completely removes the web search tab. After this patch, web searches from Thunderbird will be opened in the user's default browser, which will have a much better UX than we can provide. It will also help people who use web proxies in their browser, since they probably didn't set them up for Thunderbird, and it could be a nasty surprise for them otherwise.

Note: this doesn't completely revert everything in bug 677421; some work on that is being done in other bugs, and I didn't revert the first patch there, which adds a contentTabBaseType. I'm not sure reverting that is worth the code churn, especially since wouldn't be a clean backout. I can remove it if people really want me to, though.
Attachment #8547932 - Flags: ui-review?(josiah)
Attachment #8547932 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8547932 [details] [diff] [review]
Remove the web search tab

Review of attachment 8547932 [details] [diff] [review]:
-----------------------------------------------------------------

Pretty bit-rotted, but sure. r=mkmelin
Attachment #8547932 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8547932 [details] [diff] [review]
Remove the web search tab

Review of attachment 8547932 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't apply the patch, but the direction seems fine to me. Indeed, there is no way we will ever develop a decent web browser from within Thunderbird (Well, actually, I think that's basically called Seamonkey. :))

Sorry for the delay!
Attachment #8547932 - Flags: ui-review?(josiah) → ui-review+
Landed: https://hg.mozilla.org/comm-central/rev/710080f9a4af
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
Whiteboard: relnote
Keywords: relnote
Whiteboard: relnote
Depends on: 677421
This article needs to be updated:

https://support.mozilla.org/en-US/kb/open-search
I've updated the article. It is pending review
You need to log in before you can comment on or make changes to this bug.