Closed Bug 1120983 Opened 9 years ago Closed 9 years ago

Split manifestparser into manifestparser.py, cli.py, expression.py and maybe ini.py

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: ahal, Assigned: ahal)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Manifestparser is currently one giant file. I'd like to do a simple refactor to split it into a several smaller files. The obvious separations are the command line handling stuff, and the expression parser stuff and possibly the ini parsing stuff.

This will help me make more logical sense out of this module and allow me to add support for chunking and test runtimes etc., more easily.
Attached file MozReview Request: bz://1120983/ahal (obsolete) —
Attachment #8548880 - Flags: review?(wlachance)
/r/2477 - Bug 1120983 - [manifestparser] Split commandline handling into cli.py
/r/2479 - Bug 1120983 - [manifestparser] Split expression parsing into expression.py
/r/2481 - Bug 1120983 - [manifestparser] Split ini parsing into ini.py

Pull down these commits:

hg pull review -r ab672252a827d9595ed366cfc63c767c686af391
I was worried that removing manifestparser.py from mochitest's moz.build would break android, but apparently we don't need to do that anymore:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a826f9497f07
Comment on attachment 8548880 [details]
MozReview Request: bz://1120983/ahal

Looks good to me, assuming it passes try. I'd probably squash these changes into a single commit though.
Attachment #8548880 - Flags: review?(wlachance) → review+
The single file design is a holdover from the days before we had virtualenvs, FWIW. Glad to see code modularity is no longer blocked on crap like that. :)
https://hg.mozilla.org/mozilla-central/rev/efc0e28680fd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Blocks: chunking
Attachment #8548880 - Attachment is obsolete: true
Attachment #8619119 - Flags: review+
Attachment #8619120 - Flags: review+
Attachment #8619121 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: