1120983 - Split manifestparser into manifestparser.py, cli.py, expression.py and maybe ini.py

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

Manifestparser is currently one giant file. I'd like to do a simple refactor to split it into a several smaller files. The obvious separations are the command line handling stuff, and the expression parser stuff and possibly the ini parsing stuff.

This will help me make more logical sense out of this module and allow me to add support for chunking and test runtimes etc., more easily.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: bz://1120983/ahal

Comment 2

[Andrew Halberstadt [:ahal]]

/r/2477 - Bug 1120983 - [manifestparser] Split commandline handling into cli.py
/r/2479 - Bug 1120983 - [manifestparser] Split expression parsing into expression.py
/r/2481 - Bug 1120983 - [manifestparser] Split ini parsing into ini.py

Pull down these commits:

hg pull review -r ab672252a827d9595ed366cfc63c767c686af391

Comment 3

[Andrew Halberstadt [:ahal]]

I was worried that removing manifestparser.py from mochitest's moz.build would break android, but apparently we don't need to do that anymore:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a826f9497f07

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8548880 [details]
MozReview Request: bz://1120983/ahal

Looks good to me, assuming it passes try. I'd probably squash these changes into a single commit though.

Comment 5

[Andrew Halberstadt [:ahal]]

Try runs:
android - https://treeherder.mozilla.org/#/jobs?repo=try&revision=a826f9497f07
other - https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a3acb76b79b

Squashed and landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efc0e28680fd

Comment 6

[(not currently active) Ted Mielczarek]

The single file design is a holdover from the days before we had virtualenvs, FWIW. Glad to see code modularity is no longer blocked on crap like that. :)

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/efc0e28680fd

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1120983 - [manifestparser] Split ini parsing into ini.py

Comment 10

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1120983 - [manifestparser] Split commandline handling into cli.py

Comment 11

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1120983 - [manifestparser] Split expression parsing into expression.py