1121000 - Remove support for non-unified builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

As per the dev-platform discussion last year.

Comment 1

[(no longer active)]

Attachment: Remove support for non-unified builds

Comment 2

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3d466fde338

Comment 3

[Steve Fink [:sfink] [:s:]]

Er, why? I understand always building unified in automation, but not having a straightforward way at all to see if your code is buggy seems... suboptimal. If someone wants to go through occasionally and make our codebase valid C++, how should they do it after this patch?

Comment 4

[Valentin Gosu [:valentin]]

I agree with :sfink
Even as a courtesy to developers using an IDE we should try to keep source files individually sane.
And even if m-c/inbound don't do non-unified builds anymore, having the option do to do it locally, or on try is something I would definitely miss.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b3d466fde338

Comment 6

[(no longer active)]

(In reply to Valentin Gosu [:valentin] from comment #4)
> I agree with :sfink
> Even as a courtesy to developers using an IDE we should try to keep source
> files individually sane.
> And even if m-c/inbound don't do non-unified builds anymore, having the
> option do to do it locally, or on try is something I would definitely miss.

I filed bug 1122812 for Visual Studio projects.  There is an ongoing discussion on dev-platform if you would like to weigh in.

Comment 7

[Yuan Pengfei]

> I agree with :sfink
> Even as a courtesy to developers using an IDE we should try to keep source
> files individually sane.
> And even if m-c/inbound don't do non-unified builds anymore, having the
> option do to do it locally, or on try is something I would definitely miss.

Agree + 1
See bug 1125588