Closed Bug 1121000 Opened 5 years ago Closed 5 years ago

Remove support for non-unified builds

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As per the dev-platform discussion last year.
Depends on: 1121017
Attachment #8548882 - Flags: review?(mh+mozilla)
Attachment #8548882 - Flags: review?(mh+mozilla) → review+
Er, why? I understand always building unified in automation, but not having a straightforward way at all to see if your code is buggy seems... suboptimal. If someone wants to go through occasionally and make our codebase valid C++, how should they do it after this patch?
Depends on: 1121771
I agree with :sfink
Even as a courtesy to developers using an IDE we should try to keep source files individually sane.
And even if m-c/inbound don't do non-unified builds anymore, having the option do to do it locally, or on try is something I would definitely miss.
https://hg.mozilla.org/mozilla-central/rev/b3d466fde338
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1122769
Depends on: 1122772
Depends on: 1122783
(In reply to Valentin Gosu [:valentin] from comment #4)
> I agree with :sfink
> Even as a courtesy to developers using an IDE we should try to keep source
> files individually sane.
> And even if m-c/inbound don't do non-unified builds anymore, having the
> option do to do it locally, or on try is something I would definitely miss.

I filed bug 1122812 for Visual Studio projects.  There is an ongoing discussion on dev-platform if you would like to weigh in.
> I agree with :sfink
> Even as a courtesy to developers using an IDE we should try to keep source
> files individually sane.
> And even if m-c/inbound don't do non-unified builds anymore, having the
> option do to do it locally, or on try is something I would definitely miss.

Agree + 1
See bug 1125588
See Also: → 1442647
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.