Closed Bug 1121071 Opened 9 years ago Closed 9 years ago

Remove old call url code from the Loop panel

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
3

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38
Iteration:
38.1 - 26 Jan
backlog tech-debt

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

Now that we're shipping rooms, we don't need the old call url generation code.

Parts to be removed:

- Call url views and generation in UI
-- Associated strings
- loop.rooms.enabled pref
- Anything in MozLoopService/MozLoopAPI no longer used, e.g.
-- noteCallUrlExpiry
-- (possibly other things)
- Old ui-showcase views
Removing myself as QA contact.
QA Contact: anthony.s.hughes
This removes all I could find from the UI relating to the call url code and some strings we never used. I've started the backend (guest calls push service notification etc) in a part 2, it still needs more work to get all the tests passing.
Attachment #8549542 - Flags: review?(mdeboer)
Comment on attachment 8549542 [details] [diff] [review]
Part 1 - Remove old call url code from the Loop panel and related UI areas.

Review of attachment 8549542 [details] [diff] [review]:
-----------------------------------------------------------------

<3 code removal! I have one question, really, which might impact the test(s). r=me if you can change it to |true|

::: browser/components/loop/ui/fake-mozLoop.js
@@ -54,5 @@
>    getLoopPref: function(pref) {
>      switch(pref) {
> -      // Ensure UI for rooms is displayed in the showcase.
> -      case "rooms.enabled":
> -        return this.roomsEnabled;

If we're removing this, shouldn't 'roomsEnabled' be true by default?
Attachment #8549542 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/37ca80281932
Assignee: nobody → standard8
Iteration: --- → 38.1 - 26 Jan
Points: --- → 3
Keywords: leave-open
The second part of this bug got delayed, so as we've spread across release cycles, I'm closing this one and using bug 1140092 for the remaining work.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: qe-verify-
Flags: firefox-backlog+
Keywords: leave-open
Resolution: --- → FIXED
Summary: Remove old call url code from the Loop panel and related areas → Remove old call url code from the Loop panel
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: