1121086 - Update Recording Notices

Status: RESOLVED DUPLICATE of bug 1082695

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Jordan Santell [:jsantell] [@jsantell]]

For the new performance tool, we need some labels that make sense.

1) Start recording panel, like profiler. Currently: "Click on the [clock] button to start recording JavaScript function calls."

2) Stop recording panel, like profiler. Currently: "Click on the [clock] button again to stop profiling."

3) Scenario that's not handled currently in the profiler. If I start a profile via console.profile("test"), and click on that recording in the profiler, I get the message/panel from 2) -- which doesn't actually stop recording, as this is only for manual recordings. The text should be something like "Currently recording profile." or something.

Comment 1

[Paul Rouget [:paul]]

Couldn't we make [2] also stop console.profile()?

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

@Paul: Yes, that we could do which would also solve [3], but then we have conflicting state of the clock button in the top toolbar with the one in the main panel in [2]. Which could be fine, dunno. Something to think about. I think some message, like "Currently profiling 'test' from console.profile" or something, where the user can't do anything but wait for the consle.profileEnd(label) to be called.

Comment 3

[Victor Porof [:vporof][:vp]]

Let's talk about this in more detail in the next week's meeting. I like comment 2, though.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Let's go with these for now:


Empty notice: "Click on the [clock] button to start recording JavaScript function calls."
Recording notice: "Click on the [clock] button to stop recording."

And we'll need a new panel for when we're recording something via console calls, which we don't have yet, but can add the panel here:

console recording notice: 'Currently recording "[PROFILE NAME]".'

Comment 5

[Victor Porof [:vporof][:vp]]

Not specifically blocking v2.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Now that we know everything this tool will do when it moves up to Aurora, we should make better labels for the recording notices. The console.profile bug 1077464 adds the console recording notice message.

Comment 7

[Victor Porof [:vporof][:vp]]

P1 because needs to be done potentially before the uplift. l10n.

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

This was resolved during the labeling audit in bug 1082695.