1121132 - A broken commit message can break builds

Status: RESOLVED DUPLICATE of bug 1146035

(Testing :: Mozbase, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

The commit:
https://hg.mozilla.org/integration/fx-team/rev/291e3a83a122

The bustage:
https://treeherder.mozilla.org/logviewer.html#?job_id=1680280&repo=fx-team

Apparently mozharness doesn't like × in a commit message!

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: bz://1121132/ahal

Comment 2

[Andrew Halberstadt [:ahal]]

/r/2459 - Bug 1121132 - script.py's write_to_file should use codec.open for unicode support, r=jlund

Pull down this commit:

hg pull review -r c8963cc8dbb654118618d041345e90b8bf410540

Comment 3

[Andrew Halberstadt [:ahal]]

I think this should fix it (according to [1]). Here's a try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7be2d228d4ad

[1] https://docs.python.org/2/howto/unicode.html#reading-and-writing-unicode-data

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Andrew Halberstadt [:ahal] from comment #3)
> I think this should fix it (according to [1]). Here's a try run:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=7be2d228d4ad
> 
> [1]
> https://docs.python.org/2/howto/unicode.html#reading-and-writing-unicode-data

FYI, the original commit message that caused bustage on fx-team worked when pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9671b6be4cd (test failures unrelated).

Comment 5

[Jordan Lund (:jlund)]

https://reviewboard.mozilla.org/r/2457/#review1731

ah, this reminds me, I hadn't followed up with: https://bugzilla.mozilla.org/show_bug.cgi?id=1106342 I guess unicode characters are more popular than I thought :)

in that bug I used a similar approach which was r- by catlee. I agree it is probably safer to add a parameter to write_to_file and that encodes only when we want: e.g. for a commit message. feel free to leave with me or else add the option to write_to_file and I'll r+

Comment 6

[Andrew Halberstadt [:ahal]]

Heh, originally I had added an encoding parameter to that function, but then noticed that elsewhere in script.py we just use 'utf-8' directly, so decided to follow that convention:
https://dxr.mozilla.org/build:mozharness/source/mozharness/base/script.py#1343

Is what you're proposing simply to add an encoding='utf-8' to the method signature?

Comment 7

[Jordan Lund (:jlund)]

(In reply to Andrew Halberstadt [:ahal] from comment #6)
> Heh, originally I had added an encoding parameter to that function, but then
> noticed that elsewhere in script.py we just use 'utf-8' directly, so decided
> to follow that convention:
> https://dxr.mozilla.org/build:mozharness/source/mozharness/base/script.
> py#1343

which might be safe to follow that convention. poke catlee if you feel strongly about this. I suspect his concerns are the unknown outcome of switching all the current working instances where we call write_to_file without encoding open() 

> 
> Is what you're proposing simply to add an encoding='utf-8' to the method
> signature?

we want encoding passed but we want the default to be None (i.e. encoding=None in write_to_file meth sig). Then for the commit message, explicitly pass encoding='utf-8'.


at least that's my interpretation of https://bugzilla.mozilla.org/show_bug.cgi?id=1106342#c1

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8548430 [details]
MozReview Request: bz://1121132/ahal

putting r- to clear my bugzilla queue while the patch is iterated on.

if you feel strongly about defaulting to utf-8 over None, I don't want to block but you should pass it by catlee since he r- me on it.

Comment 9

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737495
repository: fx-team
start_time: 2015-01-20T04:28:26
who: tomcat[at]mozilla[dot]com
machine: bld-linux64-spot-179
buildname: Linux fx-team leak test build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737494
repository: fx-team
start_time: 2015-01-20T04:47:48
who: tomcat[at]mozilla[dot]com
machine: bld-linux64-spot-491
buildname: Linux fx-team build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737496
repository: fx-team
start_time: 2015-01-20T04:28:25
who: tomcat[at]mozilla[dot]com
machine: bld-linux64-spot-1026
buildname: Linux x86-64 fx-team build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737499
repository: fx-team
start_time: 2015-01-20T04:28:17
who: tomcat[at]mozilla[dot]com
machine: bld-linux64-spot-229
buildname: Linux x86-64 fx-team debug asan build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737498
repository: fx-team
start_time: 2015-01-20T04:28:13
who: tomcat[at]mozilla[dot]com
machine: bld-linux64-spot-224
buildname: Linux x86-64 fx-team asan build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 14

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737502
repository: fx-team
start_time: 2015-01-20T04:27:40
who: tomcat[at]mozilla[dot]com
machine: bld-linux64-spot-254
buildname: Linux x86-64 fx-team debug static analysis build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 15

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737501
repository: fx-team
start_time: 2015-01-20T04:28:22
who: tomcat[at]mozilla[dot]com
machine: bld-linux64-spot-136
buildname: Linux x86-64 fx-team leak test build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/tools/checkouts/mozharness/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/tools/checkouts/mozharness/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/tools/checkouts/mozharness/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 16

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737503
repository: fx-team
start_time: 2015-01-20T04:13:45
who: tomcat[at]mozilla[dot]com
machine: bld-lion-r5-092
buildname: OS X 10.7 fx-team build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/builds/slave/fx-team-osx64-0000000000000000/scripts/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/builds/slave/fx-team-osx64-0000000000000000/scripts/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/builds/slave/fx-team-osx64-0000000000000000/scripts/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/builds/slave/fx-team-osx64-0000000000000000/scripts/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/builds/slave/fx-team-osx64-0000000000000000/scripts/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/builds/slave/fx-team-osx64-0000000000000000/scripts/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/builds/slave/fx-team-osx64-0000000000000000/scripts/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/builds/slave/fx-team-osx64-0000000000000000/scripts/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 17

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737515
repository: fx-team
start_time: 2015-01-20T04:13:45
who: tomcat[at]mozilla[dot]com
machine: bld-lion-r5-059
buildname: OS X 10.7 64-bit fx-team leak test build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/builds/slave/fx-team-osx64-d-00000000000000/scripts/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/builds/slave/fx-team-osx64-d-00000000000000/scripts/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/builds/slave/fx-team-osx64-d-00000000000000/scripts/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/builds/slave/fx-team-osx64-d-00000000000000/scripts/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/builds/slave/fx-team-osx64-d-00000000000000/scripts/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/builds/slave/fx-team-osx64-d-00000000000000/scripts/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/builds/slave/fx-team-osx64-d-00000000000000/scripts/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/builds/slave/fx-team-osx64-d-00000000000000/scripts/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 18

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737595
repository: fx-team
start_time: 2015-01-20T04:29:41
who: tomcat[at]mozilla[dot]com
machine: bld-lion-r5-086
buildname: OS X 10.7 64-bit fx-team debug static analysis build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "/builds/slave/fx-team-osx64-st-an-d-00000000/scripts/mozharness/base/script.py", line 1277, in run
self.run_action(action)
File "/builds/slave/fx-team-osx64-st-an-d-00000000/scripts/mozharness/base/script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "/builds/slave/fx-team-osx64-st-an-d-00000000/scripts/mozharness/base/script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "/builds/slave/fx-team-osx64-st-an-d-00000000/scripts/mozharness/mozilla/building/buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "/builds/slave/fx-team-osx64-st-an-d-00000000/scripts/mozharness/mozilla/building/buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "/builds/slave/fx-team-osx64-st-an-d-00000000/scripts/mozharness/mozilla/buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "/builds/slave/fx-team-osx64-st-an-d-00000000/scripts/mozharness/mozilla/buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "/builds/slave/fx-team-osx64-st-an-d-00000000/scripts/mozharness/base/script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 19

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737507
repository: fx-team
start_time: 2015-01-20T04:13:45
who: tomcat[at]mozilla[dot]com
machine: b-2008-ix-0092
buildname: WINNT 5.2 fx-team build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\scripts\mozharness\base\script.py", line 1277, in run
self.run_action(action)
File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\scripts\mozharness\base\script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\scripts\mozharness\base\script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\scripts\mozharness\mozilla\building\buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\scripts\mozharness\mozilla\building\buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\scripts\mozharness\mozilla\buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\scripts\mozharness\mozilla\buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "c:\builds\moz2_slave\fx-team-w32-000000000000000000\scripts\mozharness\base\script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 20

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1737508
repository: fx-team
start_time: 2015-01-20T04:13:41
who: tomcat[at]mozilla[dot]com
machine: b-2008-ix-0151
buildname: WINNT 5.2 fx-team leak test build
revision: 424565376b6c

Uncaught exception: Traceback (most recent call last):
File "c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\scripts\mozharness\base\script.py", line 1277, in run
self.run_action(action)
File "c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\scripts\mozharness\base\script.py", line 1218, in run_action
self._possibly_run_method("preflight_%s" % method_name)
File "c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\scripts\mozharness\base\script.py", line 1160, in _possibly_run_method
return getattr(self, method_name)()
File "c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\scripts\mozharness\mozilla\building\buildbase.py", line 1362, in preflight_build
self._checkout_source()
File "c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\scripts\mozharness\mozilla\building\buildbase.py", line 1044, in _checkout_source
write_to_file=True)
File "c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\scripts\mozharness\mozilla\buildbot.py", line 100, in set_buildbot_property
return self.dump_buildbot_properties(prop_list=[prop_name], file_name=prop_name)
File "c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\scripts\mozharness\mozilla\buildbot.py", line 140, in dump_buildbot_properties
return self.write_to_file(file_name, contents)
File "c:\builds\moz2_slave\fx-team-w32-d-0000000000000000\scripts\mozharness\base\script.py", line 430, in write_to_file
fh.write(contents)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 47: ordinal not in range(128)
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 21

[Aaron Raimist [:aaronraimist]]

Attachment: bug1042619_widthxheight_devtools_v4.1.diff

Comment 22

[Aaron Raimist [:aaronraimist]]

Whoops... just uploaded this to the wrong bug. Can this be deleted?

Comment 25

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1121132 - script.py's write_to_file should use codec.open for unicode support, r=jlund