1121143 - onFolderRemovedFromQ "canceled" undefined (wrong scope)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

Attachment: bugXXX_autosync_canceled_undefined.patch

I started getting "autosyncActivities	ERROR	onFolderRemovedFromQ: ReferenceError: canceled is not defined" in the console.

From bug 1119911. the "let" makes it the wrong scope...

Comment 1

[Kent James (:rkent)]

Comment on attachment 8548410 [details] [diff] [review]
bugXXX_autosync_canceled_undefined.patch

Review of attachment 8548410 [details] [diff] [review]:
-----------------------------------------------------------------

Right, my bad. Looks good.

Comment 2

[Stefan Sitter [:ssitter]]

I noticed this error today after upgrading to Thunderbird 37.0a2 (20150114004002), i.e. the error exists on comm-aurora too.

Comment 3

[Kent James (:rkent)]

We really need someone to take the role of release manager for the aurora (and beta) channels. It would be really easy to land this bug in aurora, but nobody is really paying attention to that.

Comment 4

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/700399c45071 -> FIXED

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 8548410 [details] [diff] [review]
bugXXX_autosync_canceled_undefined.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1119911
User impact if declined: "Error: autosyncActivities ERROR onFolderRemovedFromQ: ReferenceError: canceled is not defined" is reported often in console. Don't know what is the effect on Thunderbird behavior or data.
Testing completed (on c-c, etc.): patch landed on c-c week ago
Risk to taking this patch (and alternatives if risky): risk seems low looking at the patch

Comment 6

[Kent James (:rkent)]

Comment on attachment 8548410 [details] [diff] [review]
bugXXX_autosync_canceled_undefined.patch

[Triage Comment] Might as well take this in beta 37

Comment 7

[Kent James (:rkent)]

https://hg.mozilla.org/releases/comm-beta/rev/01ae61f239cf