Closed
Bug 1121188
Opened 9 years ago
Closed 9 years ago
[Windows Management] Tapping on the blue 'Active Call' banner at the top of the screen does not take the user to the active call callscreen.
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.0 unaffected, b2g-v2.1 verified, b2g-v2.1S fixed, b2g-v2.2 verified, b2g-master verified)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | unaffected |
b2g-v2.1 | --- | verified |
b2g-v2.1S | --- | fixed |
b2g-v2.2 | --- | verified |
b2g-master | --- | verified |
People
(Reporter: jmitchell, Assigned: apastor)
References
Details
(Keywords: regression, Whiteboard: [3.0-Daily-Testing] [systemsfe])
Attachments
(2 files)
399.76 KB,
text/plain
|
Details | |
46 bytes,
text/x-github-pull-request
|
etienne
:
review+
bajaj
:
approval-gaia-v2.1+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
Description: When you are in an active call and exit out of the callscreen (ex. going to homescreen) and active call banner will appear at the top of the screen for a few seconds. This banner also returns for a few seconds every 90 seconds. Whenever the banner is visible when you press on it the user is not taken back to the callscreen. This is inconsistent with other banners / notifications in that when you click on them they do take you to the relevant area. Repro Steps: 1) Update a Flame to 20150113010202 2) Establish an active call between your device and another device. 3) Hit homescreen to leave the callscreen. 4) Tap on the blue banner at the top of the page. (if you miss it, it will show back up in 90 seconds) Actual: User is not taken to the active call screen. Expected: User will be taken to the active call screen. Environmental Variables: Device: Flame Master Build ID: 20150113010202 Gaia: 9946a490a9264b42e65385d703b28fa055ab2d42 Gecko: 3d846527576f Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76 Version: 38.0a1 (Master) Firmware Version: V18d-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Repro frequency: 9/9 See attached: Logcat ------------------------------------------------------------------------------------------ This issue also repro's in 2.2 (V18d-1) and 2.2 (V18d) Device: Flame 2.2 (KK - Nightly - Full-Flashed) Build ID: 20150112010228 Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439 Gecko: bb8d6034f5f2 Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76 Version: 37.0a1 Firmware Version: V18d-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 Device: Flame 2.2 (KK - Nightly - Full-Flashed) Build ID: 20150112010228 Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439 Gecko: bb8d6034f5f2 Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76 Version: 37.0a1 Firmware Version: V18d User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 ---------------------------------------------------------------------------------- This issues does NOT repro in 2.1 (v18d-1) or 2.0 (v18d-1) Actual results: The user is taken to the active callscreen Device: Flame 2.1 (KK - Nightly - Full-Flashed) Build ID: 20150113001255 Gaia: 836e6d74cb8b7016df555f85445893b3ff9aac12 Gecko: 074f79a929d2 Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76 Version: 34.0 (2.1) Firmware Version: V18d-1 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Device: Flame 2.0 (KK - Nightly - Full-Flashed) Build ID: 20150113000203 Gaia: 31d6c9422cd0a8213df9f96019c9ab7168ec3ab3 Gecko: c6fd5db59e0e Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76 Version: 32.0 (2.0) Firmware Version: V18d-1 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
Reporter | ||
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Comment 1•9 years ago
|
||
Functional regression of a core feature with high visibility. Requesting a window.
blocking-b2g: --- → 2.2?
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Keywords: regressionwindow-wanted
Updated•9 years ago
|
QA Contact: bzumwalt
Comment 2•9 years ago
|
||
Gaia Regression Window: Last Working B2G-Inbound Build: Device: Flame 2.2 BuildID: 20141223034736 Gaia: 456749cd1429e36ca110fcb335e4093f72117db5 Gecko: c2795447c4a1 Version: 37.0a1 (2.2) Firmware: V18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 First Broken B2G-Inbound Build: Device: Flame 2.2 BuildID: 20141223050231 Gaia: 1913c69336f2e8f8bfd97e3179e862d325aa3a99 Gecko: 56147074602d Version: 37.0a1 (2.2) Firmware: V18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 Working Gecko with Broken Gaia - Issue DOES occur Gaia: 1913c69336f2e8f8bfd97e3179e862d325aa3a99 Gecko: c2795447c4a1 Working Gaia with Broken Gecko - Issue does NOT occur Gaia: 456749cd1429e36ca110fcb335e4093f72117db5 Gecko: 56147074602d Gaia B2G-Inbound Pushlog: https://github.com/mozilla-b2g/gaia/compare/456749cd1429e36ca110fcb335e4093f72117db5...1913c69336f2e8f8bfd97e3179e862d325aa3a99 Genesis of issue appears to be due to bug 1095677
Comment 3•9 years ago
|
||
Alberto, can you please take a look at this issue? It appears that the uplift for bug 1095677 may have caused this.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(apastor)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → apastor
Flags: needinfo?(apastor)
Comment 4•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8549594 -
Flags: review?(etienne)
Updated•9 years ago
|
Whiteboard: [3.0-Daily-Testing] → [3.0-Daily-Testing] [systemsfe]
Comment 5•9 years ago
|
||
Comment on attachment 8549594 [details] [review] [PullReq] albertopq:1121188-tap-call-banner to mozilla-b2g:master Clearing for now after the IRC discussion. An integration test will definitely be welcomed :)
Attachment #8549594 -
Flags: review?(etienne)
Assignee | ||
Updated•9 years ago
|
Attachment #8549594 -
Flags: review?(etienne)
Comment 7•9 years ago
|
||
Comment on attachment 8549594 [details] [review] [PullReq] albertopq:1121188-tap-call-banner to mozilla-b2g:master Kudos on the test :) Flagging r- because this is causing a very bad regression (see github) but it's an extremely easy fix then we'll be good to go.
Attachment #8549594 -
Flags: review?(etienne) → review-
Assignee | ||
Updated•9 years ago
|
Attachment #8549594 -
Flags: review- → review?(etienne)
Updated•9 years ago
|
Attachment #8549594 -
Flags: review?(etienne) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c75b1374cc232970214b868a4dba37c8e1cfe7c5
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 9•9 years ago
|
||
[Blocking Requested - why for this release]: This blocks bug 1095677 from being uplifted to v2.1, which is itself a 2.1 blocker. Alberto, please request Gaia v2.1 and v2.2 approval on this when you get a chance.
blocking-b2g: 2.2+ → 2.1?
Flags: needinfo?(apastor)
Target Milestone: --- → 2.2 S4 (23jan)
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8549594 [details] [review] [PullReq] albertopq:1121188-tap-call-banner to mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1095677 (note that we need to uplift that first) [User impact] if declined: User can't tap on the 'active call' banner [Testing completed]: Added integration tests [Risk to taking this patch] (and alternatives if risky): Given that is a CSS change, and we added integration tests, I would say is save to uplift. [String changes made]: -
Flags: needinfo?(apastor)
Attachment #8549594 -
Flags: approval-gaia-v2.1?
Updated•9 years ago
|
blocking-b2g: 2.1? → 2.1+
Updated•9 years ago
|
Attachment #8549594 -
Flags: approval-gaia-v2.2+
Attachment #8549594 -
Flags: approval-gaia-v2.1?
Attachment #8549594 -
Flags: approval-gaia-v2.1+
Comment 11•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/8ad53cc5406fd994677a66592026164f89312d3f v2.1: https://github.com/mozilla-b2g/gaia/commit/39794d6d1a15bb74bc109f05261ec43e7df50fad
Updated•9 years ago
|
status-b2g-v2.1S:
--- → fixed
Comment 12•9 years ago
|
||
This issue is verified fixed on the latest Flame nightly builds. Results: The user is brought to the active call page when clicking the banner. Environmental Variables: Device: Flame 3.0 BuildID: 20150212010213 Gaia: d5a71cedb37dd45f439f672489db3994b349ac43 Gecko: 3094601af679 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Environmental Variables: Device: Flame 2.2 BuildID: 20150212002504 Gaia: 791e53728cd8018f1d7cf7efe06bbeb1179f0370 Gecko: 5dec207fcbeb Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 Environmental Variables: Device: Flame 2.1 BuildID: 20150212002013 Gaia: 88084bc7ef5ba6627dd09c774ef2f7fa96cbed71 Gecko: e395bfad7bc9 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 34.0 (2.1) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•