Closed Bug 1121194 Opened 9 years ago Closed 9 years ago

Support vertical panning for the flamegraph in the new performance tool

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

      No description provided.
Blocks: perf-tool-v2
Blocks: enable-perf-tool
No longer blocks: perf-tool-v2
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8575470 - Flags: review?(jsantell)
Comment on attachment 8575470 [details] [diff] [review]
v1

Review of attachment 8575470 [details] [diff] [review]:
-----------------------------------------------------------------

Slick. When trying it out, one thing I kept running into, not sure if something we can do right now. When dragging up, once you're in the overview chart area and you mouseup the overview graph will change selection, most likely moving you away of the flames you were looking at. Maybe similar to the other bugs where we should clamp down the mouse events to the originator (mousedown) graph

::: browser/devtools/shared/widgets/FlameGraph.jsm
@@ +505,3 @@
>     */
>    _drawBlocksFill: function(
> +    color, blocks, verticalOffset, dataOffset, dataScale,

how do you remember this argument order?!
Attachment #8575470 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/2834be532b6f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: